From 366998b3d6679b360291fb1993891ef35f857279 Mon Sep 17 00:00:00 2001 From: lebaudantoine Date: Fri, 2 Aug 2024 21:14:21 +0200 Subject: [PATCH] =?UTF-8?q?=F0=9F=94=87(backend)=20silence=20security=20wa?= =?UTF-8?q?rnings=20for=20reverse=20proxy=20setup?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Silenced certain Django security warnings because the application is served behind a reverse proxy. These warnings are not applicable in our deployment context, where the reverse proxy handles these security concerns. This change ensures relevant security measures are appropriately managed while avoiding unnecessary warnings. Any question? asked @rouja. /!\ actually, this commit is not working, and should be fixed. --- src/backend/meet/settings.py | 1 + src/helm/env.d/dev/values.meet.yaml.gotmpl | 1 + src/helm/env.d/preprod/values.meet.yaml.gotmpl | 1 + src/helm/env.d/production/values.meet.yaml.gotmpl | 1 + 4 files changed, 4 insertions(+) diff --git a/src/backend/meet/settings.py b/src/backend/meet/settings.py index 3192f6d5..d59dc233 100755 --- a/src/backend/meet/settings.py +++ b/src/backend/meet/settings.py @@ -71,6 +71,7 @@ class Base(Configuration): # Security ALLOWED_HOSTS = values.ListValue([]) SECRET_KEY = values.Value(None) + SILENCED_SYSTEM_CHECKS = values.ListValue([]) # Application definition ROOT_URLCONF = "meet.urls" diff --git a/src/helm/env.d/dev/values.meet.yaml.gotmpl b/src/helm/env.d/dev/values.meet.yaml.gotmpl index 099e50a8..03a21dd7 100644 --- a/src/helm/env.d/dev/values.meet.yaml.gotmpl +++ b/src/helm/env.d/dev/values.meet.yaml.gotmpl @@ -11,6 +11,7 @@ backend: DJANGO_ALLOWED_HOSTS: "*" DJANGO_SECRET_KEY: {{ .Values.djangoSecretKey }} DJANGO_SETTINGS_MODULE: meet.settings + DJANGO_SILENCED_SYSTEM_CHECKS: security.W004, security.W008 DJANGO_SUPERUSER_PASSWORD: admin DJANGO_EMAIL_HOST: "mailcatcher" DJANGO_EMAIL_PORT: 1025 diff --git a/src/helm/env.d/preprod/values.meet.yaml.gotmpl b/src/helm/env.d/preprod/values.meet.yaml.gotmpl index 378e125d..80804cdd 100644 --- a/src/helm/env.d/preprod/values.meet.yaml.gotmpl +++ b/src/helm/env.d/preprod/values.meet.yaml.gotmpl @@ -20,6 +20,7 @@ backend: name: backend key: DJANGO_SECRET_KEY DJANGO_SETTINGS_MODULE: meet.settings + DJANGO_SILENCED_SYSTEM_CHECKS: security.W004, security.W008 DJANGO_SUPERUSER_PASSWORD: secretKeyRef: name: backend diff --git a/src/helm/env.d/production/values.meet.yaml.gotmpl b/src/helm/env.d/production/values.meet.yaml.gotmpl index 78ddf49b..b16ca097 100644 --- a/src/helm/env.d/production/values.meet.yaml.gotmpl +++ b/src/helm/env.d/production/values.meet.yaml.gotmpl @@ -16,6 +16,7 @@ backend: name: backend key: DJANGO_SECRET_KEY DJANGO_SETTINGS_MODULE: meet.settings + DJANGO_SILENCED_SYSTEM_CHECKS: security.W004, security.W008 DJANGO_SUPERUSER_EMAIL: secretKeyRef: name: backend