From 4e7745811654d2aade5bf239ecb85c74c157cf4b Mon Sep 17 00:00:00 2001 From: lebaudantoine Date: Tue, 12 Nov 2024 19:15:49 +0100 Subject: [PATCH] =?UTF-8?q?=F0=9F=9A=A8(backend)=20fix=20Django=20deprecat?= =?UTF-8?q?ion=20warning=20in=20`RecordingFactory`?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Addressed a `DeprecationWarning` in `RecordingFactory` related to the `_after_postgeneration` method, which will stop saving the instance after postgeneration hooks in the next major release. To resolve this, `skip_postgeneration_save=True` was added to `RecordingFactory.Meta` to avoid extraneous save calls. Alternatively, if instance saving is needed, the save call can be moved to postgeneration hooks or by overriding `after_postgeneration`. --- src/backend/core/factories.py | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/backend/core/factories.py b/src/backend/core/factories.py index 867b0765..63f38c8b 100644 --- a/src/backend/core/factories.py +++ b/src/backend/core/factories.py @@ -32,6 +32,7 @@ class ResourceFactory(factory.django.DjangoModelFactory): class Meta: model = models.Resource + skip_postgeneration_save = True is_public = factory.Faker("boolean", chance_of_getting_true=50) @@ -45,6 +46,8 @@ class ResourceFactory(factory.django.DjangoModelFactory): else: UserResourceAccessFactory(resource=self, user=item[0], role=item[1]) + self.save() + class UserResourceAccessFactory(factory.django.DjangoModelFactory): """Create fake resource user accesses for testing.""" @@ -72,6 +75,7 @@ class RecordingFactory(factory.django.DjangoModelFactory): class Meta: model = models.Recording + skip_postgeneration_save = True room = factory.SubFactory(RoomFactory) status = models.RecordingStatusChoices.INITIATED @@ -90,6 +94,8 @@ class RecordingFactory(factory.django.DjangoModelFactory): recording=self, user=item[0], role=item[1] ) + self.save() + class UserRecordingAccessFactory(factory.django.DjangoModelFactory): """Create fake recording user accesses for testing."""