studio/meet
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

🐛(summary) fix MinIO endpoint handling in constructor

Browse Source 
Fix MinIO client configuration: I was incorrectly passing a full URL instead of
an endpoint, which caused errors in staging. Local development values did not
reflect the staging setup and were also out of sync with the backend.
This commit is contained in:
lebaudantoine
2026-01-05 15:26:38 +01:00
committed by aleb_the_flash
parent 0fe8d9b681
commit 5be7595533
3 changed files with 11 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
env.d/development/summary.dist
View File

@@ -1,7 +1,7 @@
APP_NAME="meet-app-summary-dev" APP_NAME="meet-app-summary-dev"
APP_API_TOKEN="password" APP_API_TOKEN="password"
AWS_STORAGE_BUCKET_NAME="meet-media-storage" AWS_STORAGE_BUCKET_NAME="http://meet-media-storage"
AWS_S3_ENDPOINT_URL="minio:9000" AWS_S3_ENDPOINT_URL="minio:9000"
AWS_S3_SECURE_ACCESS=false AWS_S3_SECURE_ACCESS=false

6
src/helm/env.d/dev-keycloak/values.meet.yaml.gotmpl
View File

@@ -150,7 +150,7 @@ summary:
APP_NAME: summary-microservice APP_NAME: summary-microservice
APP_API_TOKEN: password APP_API_TOKEN: password
AWS_STORAGE_BUCKET_NAME: meet-media-storage AWS_STORAGE_BUCKET_NAME: meet-media-storage
AWS_S3_ENDPOINT_URL: minio.meet.svc.cluster.local:9000 AWS_S3_ENDPOINT_URL: http://minio.meet.svc.cluster.local:9000/
AWS_S3_ACCESS_KEY_ID: meet AWS_S3_ACCESS_KEY_ID: meet
AWS_S3_SECRET_ACCESS_KEY: password AWS_S3_SECRET_ACCESS_KEY: password
AWS_S3_SECURE_ACCESS: False AWS_S3_SECURE_ACCESS: False
@@ -187,7 +187,7 @@ celeryTranscribe:
APP_NAME: summary-microservice APP_NAME: summary-microservice
APP_API_TOKEN: password APP_API_TOKEN: password
AWS_STORAGE_BUCKET_NAME: meet-media-storage AWS_STORAGE_BUCKET_NAME: meet-media-storage
AWS_S3_ENDPOINT_URL: minio.meet.svc.cluster.local:9000 AWS_S3_ENDPOINT_URL: http://minio.meet.svc.cluster.local:9000/
AWS_S3_ACCESS_KEY_ID: meet AWS_S3_ACCESS_KEY_ID: meet
AWS_S3_SECRET_ACCESS_KEY: password AWS_S3_SECRET_ACCESS_KEY: password
AWS_S3_SECURE_ACCESS: False AWS_S3_SECURE_ACCESS: False
@@ -225,7 +225,7 @@ celerySummarize:
APP_NAME: summary-microservice APP_NAME: summary-microservice
APP_API_TOKEN: password APP_API_TOKEN: password
AWS_STORAGE_BUCKET_NAME: meet-media-storage AWS_STORAGE_BUCKET_NAME: meet-media-storage
AWS_S3_ENDPOINT_URL: minio.meet.svc.cluster.local:9000 AWS_S3_ENDPOINT_URL: http://minio.meet.svc.cluster.local:9000/
AWS_S3_ACCESS_KEY_ID: meet AWS_S3_ACCESS_KEY_ID: meet
AWS_S3_SECRET_ACCESS_KEY: password AWS_S3_SECRET_ACCESS_KEY: password
AWS_S3_SECURE_ACCESS: False AWS_S3_SECURE_ACCESS: False

8
src/summary/summary/core/file_service.py
View File

@@ -21,8 +21,14 @@ class FileService:
"""Initialize FileService with MinIO client and configuration.""" """Initialize FileService with MinIO client and configuration."""
self._logger = logger self._logger = logger
endpoint = (
settings.aws_s3_endpoint_url.removeprefix("https://")
.removeprefix("http://")
.rstrip("/")
)
self._minio_client = Minio( self._minio_client = Minio(
settings.aws_s3_endpoint_url, endpoint,
access_key=settings.aws_s3_access_key_id, access_key=settings.aws_s3_access_key_id,
secret_key=settings.aws_s3_secret_access_key.get_secret_value(), secret_key=settings.aws_s3_secret_access_key.get_secret_value(),
secure=settings.aws_s3_secure_access, secure=settings.aws_s3_secure_access,