studio/meet
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

🐛(frontend) fix infinite loading for unauthenticated users on downloads

Browse Source 
Reorganize exception handling in recording download screen to prevent
unauthenticated users from getting stuck in loading state. Caught by
production users - my bad;
This commit is contained in:
lebaudantoine
2025-07-11 12:04:52 +02:00
committed by aleb_the_flash
parent 3368a9b6af
commit 5c8c81f97b
1 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/frontend/src/features/recording/routes/RecordingDownload.tsx
View File

@@ -27,11 +27,11 @@ export const RecordingDownload = () => {
enabled: !!recordingId, enabled: !!recordingId,
}) })
if (isLoading || !data || isAuthLoading) { if (isLoggedIn === undefined || isAuthLoading) {
return <LoadingScreen /> return <LoadingScreen />
} }
if (!isLoggedIn) { if (isLoggedIn === false && !isAuthLoading) {
return ( return (
<ErrorScreen <ErrorScreen
title={t('authentication.title')} title={t('authentication.title')}
@@ -40,7 +40,11 @@ export const RecordingDownload = () => {
) )
} }
if (isError) { if (isLoading) {
return <LoadingScreen />
}
if (isError || !data) {
return <ErrorScreen title={t('error.title')} body={t('error.body')} /> return <ErrorScreen title={t('error.title')} body={t('error.body')} />
} }