From 67d004fbda742c6767312750f6519e46cc86e709 Mon Sep 17 00:00:00 2001 From: lebaudantoine Date: Mon, 4 Nov 2024 14:25:20 +0100 Subject: [PATCH] =?UTF-8?q?=E2=99=BB=EF=B8=8F(backend)=20refactor=20try/ex?= =?UTF-8?q?cept=20when=20getting=20a=20room?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Be more Pythonist simplifying try except while tracking when user is getting a room. --- src/backend/core/api/viewsets.py | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/src/backend/core/api/viewsets.py b/src/backend/core/api/viewsets.py index fa662946..0d7d22c6 100644 --- a/src/backend/core/api/viewsets.py +++ b/src/backend/core/api/viewsets.py @@ -186,13 +186,6 @@ class RoomViewSet( """ try: instance = self.get_object() - - analytics.track( - user=self.request.user, - event="Get Room", - properties={"slug": instance.slug}, - ) - except Http404: if not settings.ALLOW_UNREGISTERED_ROOMS: raise @@ -210,6 +203,11 @@ class RoomViewSet( } else: data = self.get_serializer(instance).data + analytics.track( + user=self.request.user, + event="Get Room", + properties={"slug": instance.slug}, + ) return drf_response.Response(data)