studio/meet
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

🐛(backend) catch all request exceptions in summary service integration

Browse Source 
Replace narrow HTTPError handling with broad RequestException
catch to prevent crashes from network failures (ConnectionError),
timeouts (30s exceeded), SSL/TLS errors, and other request failures
that previously caused unhandled exceptions.

Ensures consistent False return and proper logging for all network-related
failures instead of crashing application when summary service
communication encounters infrastructure issues beyond HTTP errors.
This commit is contained in:
lebaudantoine
2025-10-23 05:26:30 +02:00
committed by aleb_the_flash
parent 315d48a501
commit 6cd54f7e1e
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/backend/core/recording/event/notification.py
View File

@@ -158,9 +158,9 @@ class NotificationService:
timeout=30, timeout=30,
) )
response.raise_for_status() response.raise_for_status()
except requests.HTTPError as exc: except requests.RequestException as exc:
logger.exception( logger.exception(
"Summary service HTTP error for recording %s. URL: %s. Exception: %s", "Summary service error for recording %s. URL: %s. Exception: %s",
recording.id, recording.id,
settings.SUMMARY_SERVICE_ENDPOINT, settings.SUMMARY_SERVICE_ENDPOINT,
exc, exc,