♻️(frontend) refactor Grist forms urls in a single constants file

Consolidate all Grist forms into a single file to improve code organization
and enhance maintainability.
This commit is contained in:
lebaudantoine
2025-04-04 15:47:01 +02:00
committed by aleb_the_flash
parent 33a94da636
commit 70ffb758c7
4 changed files with 9 additions and 9 deletions

View File

@@ -2,7 +2,7 @@ import { css } from '@/styled-system/css'
import { RiErrorWarningLine, RiExternalLinkLine } from '@remixicon/react' import { RiErrorWarningLine, RiExternalLinkLine } from '@remixicon/react'
import { useTranslation } from 'react-i18next' import { useTranslation } from 'react-i18next'
import { Text, A } from '@/primitives' import { Text, A } from '@/primitives'
import { GRIST_FORM } from '@/utils/constants' import { GRIST_FEEDBACKS_FORM } from '@/utils/constants'
export const FeedbackBanner = () => { export const FeedbackBanner = () => {
const { t } = useTranslation() const { t } = useTranslation()
@@ -35,7 +35,7 @@ export const FeedbackBanner = () => {
gap: 0.25, gap: 0.25,
})} })}
> >
<A href={GRIST_FORM} target="_blank" size="sm"> <A href={GRIST_FEEDBACKS_FORM} target="_blank" size="sm">
{t('feedback.cta')} {t('feedback.cta')}
</A> </A>
<RiExternalLinkLine size={16} aria-hidden="true" /> <RiExternalLinkLine size={16} aria-hidden="true" />

View File

@@ -8,10 +8,7 @@ import { Button, LinkButton } from '@/primitives'
import { RiArrowLeftSLine, RiArrowRightSLine } from '@remixicon/react' import { RiArrowLeftSLine, RiArrowRightSLine } from '@remixicon/react'
import { useState } from 'react' import { useState } from 'react'
import { useTranslation } from 'react-i18next' import { useTranslation } from 'react-i18next'
import { BETA_USERS_FORM_URL } from '@/utils/constants'
// todo - extract in a proper env variable
const BETA_USERS_FORM_URL =
'https://grist.numerique.gouv.fr/o/docs/forms/3fFfvJoTBEQ6ZiMi8zsQwX/17'
const Heading = styled('h2', { const Heading = styled('h2', {
base: { base: {

View File

@@ -2,14 +2,14 @@ import { RiMegaphoneLine } from '@remixicon/react'
import { MenuItem } from 'react-aria-components' import { MenuItem } from 'react-aria-components'
import { useTranslation } from 'react-i18next' import { useTranslation } from 'react-i18next'
import { menuRecipe } from '@/primitives/menuRecipe' import { menuRecipe } from '@/primitives/menuRecipe'
import { GRIST_FORM } from '@/utils/constants' import { GRIST_FEEDBACKS_FORM } from '@/utils/constants'
export const FeedbackMenuItem = () => { export const FeedbackMenuItem = () => {
const { t } = useTranslation('rooms', { keyPrefix: 'options.items' }) const { t } = useTranslation('rooms', { keyPrefix: 'options.items' })
return ( return (
<MenuItem <MenuItem
href={GRIST_FORM} href={GRIST_FEEDBACKS_FORM}
target="_blank" target="_blank"
className={menuRecipe({ icon: true, variant: 'dark' }).item} className={menuRecipe({ icon: true, variant: 'dark' }).item}
> >

View File

@@ -1,2 +1,5 @@
export const GRIST_FORM = export const GRIST_FEEDBACKS_FORM =
'https://grist.numerique.gouv.fr/o/docs/forms/1YrfNP1QSSy8p2gCxMFnSf/4' as const 'https://grist.numerique.gouv.fr/o/docs/forms/1YrfNP1QSSy8p2gCxMFnSf/4' as const
export const BETA_USERS_FORM_URL =
'https://grist.numerique.gouv.fr/o/docs/forms/3fFfvJoTBEQ6ZiMi8zsQwX/17' as const