From 716e11b5b3372e23761ab95ea809bf90d611d763 Mon Sep 17 00:00:00 2001 From: Cyril Date: Fri, 30 Jan 2026 14:49:01 +0100 Subject: [PATCH] =?UTF-8?q?=E2=99=BF=EF=B8=8F(frontend)=20fix=20form=20lab?= =?UTF-8?q?els=20and=20autocomplete=20wiring?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Ensure labels map to inputs and avoid empty describedby output --- CHANGELOG.md | 4 ++++ src/frontend/src/features/rooms/components/Join.tsx | 6 ++---- src/frontend/src/primitives/Field.tsx | 4 +++- 3 files changed, 9 insertions(+), 5 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 78089779..00e8daa3 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,6 +8,10 @@ and this project adheres to ## [Unreleased] +### Changed + +- ♿️(frontend) fix form labels and autocomplete wiring #932 + ## [1.5.0] - 2026-01-28 ### Changed diff --git a/src/frontend/src/features/rooms/components/Join.tsx b/src/frontend/src/features/rooms/components/Join.tsx index b11c15b6..5561b621 100644 --- a/src/frontend/src/features/rooms/components/Join.tsx +++ b/src/frontend/src/features/rooms/components/Join.tsx @@ -446,16 +446,14 @@ export const Join = ({ type="text" onChange={saveUsername} label={t('usernameLabel')} - aria-label={t('usernameLabel')} + id="input-name" defaultValue={username} validate={(value) => !value && t('errors.usernameEmpty')} wrapperProps={{ noMargin: true, fullWidth: true, }} - labelProps={{ - center: true, - }} + autoComplete="name" maxLength={50} /> diff --git a/src/frontend/src/primitives/Field.tsx b/src/frontend/src/primitives/Field.tsx index d430a153..d8e65677 100644 --- a/src/frontend/src/primitives/Field.tsx +++ b/src/frontend/src/primitives/Field.tsx @@ -138,7 +138,9 @@ export const Field = ({ const LabelAndDescription = ( <> {label} - {description} + {description ? ( + {description} + ) : null} ) const RACFieldErrors = (