From 7ec3e481ffdb5288cc9788d2988e3e171ba3be98 Mon Sep 17 00:00:00 2001
From: lebaudantoine <lebaud.antoine131@gmail.com>
Date: Fri, 22 Aug 2025 01:25:31 +0200
Subject: [PATCH] =?UTF-8?q?=E2=99=BF=EF=B8=8F(frontend)=20update=20device?=
 =?UTF-8?q?=20control=20tooltips=20to=20reflect=20settings=20dialog?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Update tooltip and aria-label text for in-room device controls to
indicate they now open comprehensive settings dialog instead of simple
device selection.
---
 .../components/controls/Device/AudioDevicesControl.tsx       | 2 +-
 .../livekit/components/controls/Device/SettingsButton.tsx    | 4 ++--
 .../components/controls/Device/VideoDeviceControl.tsx        | 2 +-
 src/frontend/src/locales/de/rooms.json                       | 5 ++++-
 src/frontend/src/locales/en/rooms.json                       | 5 ++++-
 src/frontend/src/locales/fr/rooms.json                       | 5 ++++-
 src/frontend/src/locales/nl/rooms.json                       | 5 ++++-
 7 files changed, 20 insertions(+), 8 deletions(-)

diff --git a/src/frontend/src/features/rooms/livekit/components/controls/Device/AudioDevicesControl.tsx b/src/frontend/src/features/rooms/livekit/components/controls/Device/AudioDevicesControl.tsx
index 9a310e2e..62cfad63 100644
--- a/src/frontend/src/features/rooms/livekit/components/controls/Device/AudioDevicesControl.tsx
+++ b/src/frontend/src/features/rooms/livekit/components/controls/Device/AudioDevicesControl.tsx
@@ -48,7 +48,7 @@ export const AudioDevicesControl = ({
 
   const kind = 'audioinput'
   const cannotUseDevice = useCannotUseDevice(kind)
-  const selectLabel = t(`${kind}.choose`)
+  const selectLabel = t(`settings.${SettingsDialogExtendedKey.AUDIO}`)
 
   return (
     <div
diff --git a/src/frontend/src/features/rooms/livekit/components/controls/Device/SettingsButton.tsx b/src/frontend/src/features/rooms/livekit/components/controls/Device/SettingsButton.tsx
index 38b305ac..b17009a9 100644
--- a/src/frontend/src/features/rooms/livekit/components/controls/Device/SettingsButton.tsx
+++ b/src/frontend/src/features/rooms/livekit/components/controls/Device/SettingsButton.tsx
@@ -16,8 +16,8 @@ export const SettingsButton = ({
     <Button
       size="sm"
       square
-      tooltip={t('settings')}
-      aria-label={t('settings')}
+      tooltip={t(`settings.${settingTab}`)}
+      aria-label={t(`settings.${settingTab}`)}
       variant="primaryDark"
       onPress={() => {
         setDefaultSelectedKey(settingTab)
diff --git a/src/frontend/src/features/rooms/livekit/components/controls/Device/VideoDeviceControl.tsx b/src/frontend/src/features/rooms/livekit/components/controls/Device/VideoDeviceControl.tsx
index e12542ae..1f305597 100644
--- a/src/frontend/src/features/rooms/livekit/components/controls/Device/VideoDeviceControl.tsx
+++ b/src/frontend/src/features/rooms/livekit/components/controls/Device/VideoDeviceControl.tsx
@@ -73,7 +73,7 @@ export const VideoDeviceControl = ({
     } as VideoCaptureOptions)
   }
 
-  const selectLabel = t(`${kind}.choose`)
+  const selectLabel = t(`settings.${SettingsDialogExtendedKey.VIDEO}`)
 
   return (
     <div
diff --git a/src/frontend/src/locales/de/rooms.json b/src/frontend/src/locales/de/rooms.json
index 72f2bd52..da8d008e 100644
--- a/src/frontend/src/locales/de/rooms.json
+++ b/src/frontend/src/locales/de/rooms.json
@@ -11,7 +11,10 @@
     "loading": "Laden…",
     "select": "Wählen Sie einen Wert",
     "permissionsNeeded": "Genehmigung erforderlich",
-    "settings": "Einstellungen",
+    "settings": {
+      "audio": "Audioeinstellungen",
+      "video": "Videoeinstellungen"
+    },
     "videoinput": {
       "choose": "Kamera auswählen",
       "permissionsNeeded": "Kamera auswählen - genehmigung erforderlich",
diff --git a/src/frontend/src/locales/en/rooms.json b/src/frontend/src/locales/en/rooms.json
index 9063ae03..59cffb9f 100644
--- a/src/frontend/src/locales/en/rooms.json
+++ b/src/frontend/src/locales/en/rooms.json
@@ -11,7 +11,10 @@
     "loading": "Loading…",
     "select": "Select a value",
     "permissionsNeeded": "Permission needed",
-    "settings": "Settings",
+    "settings": {
+      "audio": "Audio settings",
+      "video": "Video settings"
+    },
     "videoinput": {
       "choose": "Select camera",
       "permissionsNeeded": "Select camera - permission needed",
diff --git a/src/frontend/src/locales/fr/rooms.json b/src/frontend/src/locales/fr/rooms.json
index 7b1587ae..643708c7 100644
--- a/src/frontend/src/locales/fr/rooms.json
+++ b/src/frontend/src/locales/fr/rooms.json
@@ -11,7 +11,10 @@
     "loading": "Chargement…",
     "select": "Sélectionnez une valeur",
     "permissionsNeeded": "Autorisations nécessaires",
-    "settings": "Paramètres",
+    "settings": {
+      "audio": "Paramètres audio",
+      "video": "Paramètres video"
+    },
     "videoinput": {
       "choose": "Choisir la webcam",
       "permissionsNeeded": "Choisir la webcam - autorisations nécessaires",
diff --git a/src/frontend/src/locales/nl/rooms.json b/src/frontend/src/locales/nl/rooms.json
index e29ea489..a0f22d15 100644
--- a/src/frontend/src/locales/nl/rooms.json
+++ b/src/frontend/src/locales/nl/rooms.json
@@ -11,7 +11,10 @@
     "loading": "Bezig met laden…",
     "select": "Selecteer een waarde",
     "permissionsNeeded": "Toestemming vereist",
-    "settings": "Instellingen",
+    "settings": {
+      "audio": "Audio-instellingen",
+      "video": "Video-instellingen"
+    },
     "videoinput": {
       "choose": "Selecteer camera",
       "permissionsNeeded": "Selecteer camera - Toestemming vereist",