From 886919c23d349e26d8eef82a8d9dd0c6d8212176 Mon Sep 17 00:00:00 2001 From: lebaudantoine Date: Fri, 18 Apr 2025 10:44:48 +0200 Subject: [PATCH] =?UTF-8?q?=F0=9F=90=9B(backend)=20update=20media=20auth?= =?UTF-8?q?=20endpoint=20to=20check=20correct=20recording=20status?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Modify media auth endpoint to properly handle recordings with "Notification succeeded" status alongside "Saved" status. Previous code incorrectly expected only "Saved" status, causing access issues after email notifications were sent and status was updated. --- src/backend/core/models.py | 5 ++++- src/backend/core/tests/test_models_recording.py | 5 ++++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/src/backend/core/models.py b/src/backend/core/models.py index 49e8b732..77ef198f 100644 --- a/src/backend/core/models.py +++ b/src/backend/core/models.py @@ -581,7 +581,10 @@ class Recording(BaseModel): @property def is_saved(self) -> bool: """Check if the recording is in a saved state.""" - return self.status == RecordingStatusChoices.SAVED + return self.status in { + RecordingStatusChoices.NOTIFICATION_SUCCEEDED, + RecordingStatusChoices.SAVED, + } @property def extension(self): diff --git a/src/backend/core/tests/test_models_recording.py b/src/backend/core/tests/test_models_recording.py index e45023be..4b6ec38d 100644 --- a/src/backend/core/tests/test_models_recording.py +++ b/src/backend/core/tests/test_models_recording.py @@ -256,10 +256,13 @@ def test_models_recording_key_for_unknown_mode(settings): def test_models_recording_is_saved_true(): - """Test is_saved property returns True for SAVED status.""" + """Test is_saved property returns True for SAVED and NOTIFICATION_SUCCEEDED status.""" recording = RecordingFactory(status=RecordingStatusChoices.SAVED) assert recording.is_saved is True + recording = RecordingFactory(status=RecordingStatusChoices.NOTIFICATION_SUCCEEDED) + assert recording.is_saved is True + def test_models_recording_is_saved_false_active(): """Test is_saved property returns False for ACTIVE status."""