From a987830fb37ddd480498197bfad59969916b5fd9 Mon Sep 17 00:00:00 2001 From: lebaudantoine Date: Wed, 13 Nov 2024 11:22:59 +0100 Subject: [PATCH] =?UTF-8?q?=F0=9F=97=91=EF=B8=8F(backend)=20remove=20usele?= =?UTF-8?q?ss=20methods=20on=20User?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit While removing analytics code in 15e922f, I forgot to remove related code in the User model, used nowwhere else. Oopsie. Fixed it! --- src/backend/core/models.py | 7 ------- src/backend/core/tests/test_models_users.py | 9 --------- 2 files changed, 16 deletions(-) diff --git a/src/backend/core/models.py b/src/backend/core/models.py index 381dbd24..e9cec439 100644 --- a/src/backend/core/models.py +++ b/src/backend/core/models.py @@ -207,13 +207,6 @@ class User(AbstractBaseUser, BaseModel, auth_models.PermissionsMixin): """ return [] - @property - def email_anonymized(self): - """Anonymize the email address by replacing the local part with asterisks.""" - if not self.email: - return "" - return f"***@{self.email.split('@')[1]}" - def get_resource_roles(resource: models.Model, user: User) -> List[str]: """ diff --git a/src/backend/core/tests/test_models_users.py b/src/backend/core/tests/test_models_users.py index 8e313b8b..edea5bb9 100644 --- a/src/backend/core/tests/test_models_users.py +++ b/src/backend/core/tests/test_models_users.py @@ -44,12 +44,3 @@ def test_models_users_send_mail_main_missing(): user.email_user("my subject", "my message") assert str(excinfo.value) == "User has no email address." - - -def test_models_users_email_anonymized(): - """The user's email should be anonymized if it exists.""" - user = factories.UserFactory(email="john.doe@world.com") - assert user.email_anonymized == "***@world.com" - - user = factories.UserFactory(email=None) - assert user.email_anonymized == ""