♻️(backend) extract livekit API client creation to reusable utility

Create dedicated utility function for livekit API client initialization.
Centralizes configuration logic including custom session handling for SSL
verification. Improves code reuse across backend components that interact
with LiveKit.

src/backend/core/tests/services/test_lobby.py

@@ -776,9 +776,10 @@ def test_update_participant_status_success(mock_cache, lobby_service, participan
     lobby_service._get_cache_key.assert_called_once_with(room.id, participant_id)
 
 
-@mock.patch("core.services.lobby.LiveKitAPI")
-def test_notify_participants_success_no_room(mock_livekit_api, lobby_service):
+@mock.patch("core.utils.create_livekit_client")
+def test_notify_participants_success_no_room(mock_create_livekit_client, lobby_service):
     """Test the notify_participants method when the LiveKit room doesn't exist yet."""
+
     room = RoomFactory(access_level=RoomAccessLevel.RESTRICTED)
 
     # Set up the mock LiveKitAPI and its behavior
@@ -794,15 +795,11 @@ def test_notify_participants_success_no_room(mock_livekit_api, lobby_service):
 
     mock_api_instance.room.list_rooms = mock.AsyncMock(return_value=MockResponse())
     mock_api_instance.aclose = mock.AsyncMock()
-    mock_livekit_api.return_value = mock_api_instance
+    mock_create_livekit_client.return_value = mock_api_instance
 
     # Act
     lobby_service.notify_participants(room.id)
 
-    # Assert
-    # Verify the API was initialized with correct configuration
-    mock_livekit_api.assert_called_once_with(**settings.LIVEKIT_CONFIGURATION)
-
     # Verify that the service checked for existing rooms
     mock_api_instance.room.list_rooms.assert_called_once()
 
@@ -813,8 +810,8 @@ def test_notify_participants_success_no_room(mock_livekit_api, lobby_service):
     mock_api_instance.aclose.assert_called_once()
 
 
-@mock.patch("core.services.lobby.LiveKitAPI")
-def test_notify_participants_success(mock_livekit_api, lobby_service):
+@mock.patch("core.utils.create_livekit_client")
+def test_notify_participants_success(mock_create_livekit_client, lobby_service):
     """Test successful participant notification."""
     room = RoomFactory(access_level=RoomAccessLevel.RESTRICTED)
     # Set up the mock LiveKitAPI and its behavior
@@ -830,14 +827,11 @@ def test_notify_participants_success(mock_livekit_api, lobby_service):
     mock_api_instance.room.list_rooms = mock.AsyncMock(return_value=MockResponse())
 
     mock_api_instance.aclose = mock.AsyncMock()
-    mock_livekit_api.return_value = mock_api_instance
+    mock_create_livekit_client.return_value = mock_api_instance
 
     # Call the function
     lobby_service.notify_participants(room.id)
 
-    # Verify the API was called correctly
-    mock_livekit_api.assert_called_once_with(**settings.LIVEKIT_CONFIGURATION)
-
     # Verify that the service checked for existing rooms
     mock_api_instance.room.list_rooms.assert_called_once()
 
@@ -855,8 +849,8 @@ def test_notify_participants_success(mock_livekit_api, lobby_service):
     mock_api_instance.aclose.assert_called_once()
 
 
-@mock.patch("core.services.lobby.LiveKitAPI")
-def test_notify_participants_error(mock_livekit_api, lobby_service):
+@mock.patch("core.utils.create_livekit_client")
+def test_notify_participants_error(mock_create_livekit_client, lobby_service):
     """Test participant notification with API error."""
     room = RoomFactory(access_level=RoomAccessLevel.RESTRICTED)
     # Set up the mock LiveKitAPI and its behavior
@@ -874,7 +868,7 @@ def test_notify_participants_error(mock_livekit_api, lobby_service):
     mock_api_instance.room.list_rooms = mock.AsyncMock(return_value=MockResponse())
 
     mock_api_instance.aclose = mock.AsyncMock()
-    mock_livekit_api.return_value = mock_api_instance
+    mock_create_livekit_client.return_value = mock_api_instance
 
     # Call the function and expect an exception
     with pytest.raises(
@@ -882,9 +876,6 @@ def test_notify_participants_error(mock_livekit_api, lobby_service):
     ):
         lobby_service.notify_participants(room.id)
 
-    # Verify the API was called correctly
-    mock_livekit_api.assert_called_once_with(**settings.LIVEKIT_CONFIGURATION)
-
     # Verify that the service checked for existing rooms
     mock_api_instance.room.list_rooms.assert_called_once()
 

src/backend/core/tests/test_utils.py

@@ -0,0 +1,60 @@
+"""
+Test utils functions
+"""
+
+from unittest import mock
+
+from core.utils import create_livekit_client
+
+
+@mock.patch("asyncio.get_running_loop")
+@mock.patch("core.utils.LiveKitAPI")
+def test_create_livekit_client_ssl_enabled(
+    mock_livekit_api, mock_get_running_loop, settings
+):
+    """Test LiveKitAPI client creation with SSL verification enabled."""
+    mock_get_running_loop.return_value = mock.MagicMock()
+    settings.LIVEKIT_VERIFY_SSL = True
+
+    create_livekit_client()
+
+    mock_livekit_api.assert_called_once_with(
+        **settings.LIVEKIT_CONFIGURATION, session=None
+    )
+
+
+@mock.patch("core.utils.aiohttp.ClientSession")
+@mock.patch("asyncio.get_running_loop")
+@mock.patch("core.utils.LiveKitAPI")
+def test_create_livekit_client_ssl_disabled(
+    mock_livekit_api, mock_get_running_loop, mock_client_session, settings
+):
+    """Test LiveKitAPI client creation with SSL verification disabled."""
+    mock_get_running_loop.return_value = mock.MagicMock()
+    mock_session_instance = mock.MagicMock()
+    mock_client_session.return_value = mock_session_instance
+    settings.LIVEKIT_VERIFY_SSL = False
+
+    create_livekit_client()
+
+    mock_livekit_api.assert_called_once_with(
+        **settings.LIVEKIT_CONFIGURATION, session=mock_session_instance
+    )
+
+
+@mock.patch("asyncio.get_running_loop")
+@mock.patch("core.utils.LiveKitAPI")
+def test_create_livekit_client_custom_configuration(
+    mock_livekit_api, mock_get_running_loop
+):
+    """Test LiveKitAPI client creation with custom configuration."""
+    mock_get_running_loop.return_value = mock.MagicMock()
+    custom_configuration = {
+        "api_key": "mock_key",
+        "api_secret": "mock_secret",
+        "url": "http://mock-url.com",
+    }
+
+    create_livekit_client(custom_configuration)
+
+    mock_livekit_api.assert_called_once_with(**custom_configuration, session=None)