From b261f2ee5b55dfe422da581cd9da623883a81175 Mon Sep 17 00:00:00 2001 From: lebaudantoine Date: Fri, 26 Jul 2024 00:41:17 +0200 Subject: [PATCH] =?UTF-8?q?=F0=9F=9B=82(backend)=20disallow=20unregistered?= =?UTF-8?q?=20rooms?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Require users to create a room in the database before requesting a LiveKit token. If user request an access token for a room that doesn't exist in our db, its request would end in a 404 error. Ensure that rooms must be registered by a user before they can be accessed. By default, all created rooms remain public, allowing anonymous users to join any room created by a logged-in user. However, anonymous users cannot create rooms themselves. --- env.d/development/common.dist | 1 + src/helm/env.d/dev/values.meet.yaml.gotmpl | 2 ++ src/helm/env.d/preprod/values.meet.yaml.gotmpl | 1 + src/helm/env.d/production/values.meet.yaml.gotmpl | 1 + src/helm/env.d/staging/values.meet.yaml.gotmpl | 1 + 5 files changed, 6 insertions(+) diff --git a/env.d/development/common.dist b/env.d/development/common.dist index b0a31f4a..5018b1e4 100644 --- a/env.d/development/common.dist +++ b/env.d/development/common.dist @@ -41,3 +41,4 @@ OIDC_AUTH_REQUEST_EXTRA_PARAMS={"acr_values": "eidas1"} LIVEKIT_API_SECRET=secret LIVEKIT_API_KEY=devkey LIVEKIT_API_URL=http://localhost:7880 +ALLOW_UNREGISTERED_ROOMS=False diff --git a/src/helm/env.d/dev/values.meet.yaml.gotmpl b/src/helm/env.d/dev/values.meet.yaml.gotmpl index 1c4bf58a..099e50a8 100644 --- a/src/helm/env.d/dev/values.meet.yaml.gotmpl +++ b/src/helm/env.d/dev/values.meet.yaml.gotmpl @@ -47,6 +47,8 @@ backend: {{- end }} LIVEKIT_API_URL: https://livekit.127.0.0.1.nip.io/ ANALYTICS_KEY: xwhoIMCZ8PBRjQ2t + ALLOW_UNREGISTERED_ROOMS: False + migrate: command: diff --git a/src/helm/env.d/preprod/values.meet.yaml.gotmpl b/src/helm/env.d/preprod/values.meet.yaml.gotmpl index 1c7dc856..58a31949 100644 --- a/src/helm/env.d/preprod/values.meet.yaml.gotmpl +++ b/src/helm/env.d/preprod/values.meet.yaml.gotmpl @@ -93,6 +93,7 @@ backend: name: backend key: LIVEKIT_API_KEY LIVEKIT_API_URL: https://livekit-preprod.beta.numerique.gouv.fr + ALLOW_UNREGISTERED_ROOMS: False createsuperuser: command: diff --git a/src/helm/env.d/production/values.meet.yaml.gotmpl b/src/helm/env.d/production/values.meet.yaml.gotmpl index 6eeeb1d2..e663a211 100644 --- a/src/helm/env.d/production/values.meet.yaml.gotmpl +++ b/src/helm/env.d/production/values.meet.yaml.gotmpl @@ -94,6 +94,7 @@ backend: key: LIVEKIT_API_KEY LIVEKIT_API_URL: https://livekit-preprod.beta.numerique.gouv.fr ANALYTICS_KEY: mwuxTKi8o2xzWH54 + ALLOW_UNREGISTERED_ROOMS: False createsuperuser: command: diff --git a/src/helm/env.d/staging/values.meet.yaml.gotmpl b/src/helm/env.d/staging/values.meet.yaml.gotmpl index 634842a5..7dcaa71c 100644 --- a/src/helm/env.d/staging/values.meet.yaml.gotmpl +++ b/src/helm/env.d/staging/values.meet.yaml.gotmpl @@ -94,6 +94,7 @@ backend: key: LIVEKIT_API_KEY LIVEKIT_API_URL: https://livekit-preprod.beta.numerique.gouv.fr ANALYTICS_KEY: Roi1k6IAc2DEqHB0 + ALLOW_UNREGISTERED_ROOMS: False createsuperuser: command: