From bc53916c68a2e982954743eb29324c8ea9876562 Mon Sep 17 00:00:00 2001
From: lebaudantoine <lebaud.antoine131@gmail.com>
Date: Fri, 18 Apr 2025 10:52:46 +0200
Subject: [PATCH] =?UTF-8?q?=F0=9F=9A=B8(frontend)=20prevent=20auth=20scree?=
 =?UTF-8?q?n=20flashing=20during=20user=20data=20fetch?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Fix UI flickering where authentication screen briefly appeared for logged-in
users during initial data loading. Address issue caused by increased request
delay from waterfall cascade introduced by configurable silent auth setting.
---
 src/frontend/src/features/auth/api/useUser.tsx                | 1 +
 .../src/features/recording/routes/RecordingDownload.tsx       | 4 ++--
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/frontend/src/features/auth/api/useUser.tsx b/src/frontend/src/features/auth/api/useUser.tsx
index 82c44486..a243944b 100644
--- a/src/frontend/src/features/auth/api/useUser.tsx
+++ b/src/frontend/src/features/auth/api/useUser.tsx
@@ -65,6 +65,7 @@ export const useUser = (
     refetch: query.refetch,
     user: isLoggedOut ? undefined : (query.data as ApiUser | undefined),
     isLoggedIn,
+    isLoading: query.isLoading,
     logout,
   }
 }
diff --git a/src/frontend/src/features/recording/routes/RecordingDownload.tsx b/src/frontend/src/features/recording/routes/RecordingDownload.tsx
index 543dd9ac..b72f5eb6 100644
--- a/src/frontend/src/features/recording/routes/RecordingDownload.tsx
+++ b/src/frontend/src/features/recording/routes/RecordingDownload.tsx
@@ -17,7 +17,7 @@ import { RecordingStatus } from '@/features/recording'
 export const RecordingDownload = () => {
   const { t } = useTranslation('recording')
   const { recordingId } = useParams()
-  const { isLoggedIn } = useUser()
+  const { isLoggedIn, isLoading: isAuthLoading } = useUser()
 
   const { data, isLoading, isError } = useQuery({
     queryKey: ['recording', recordingId],
@@ -26,7 +26,7 @@ export const RecordingDownload = () => {
     enabled: !!recordingId,
   })
 
-  if (isLoading || !data) {
+  if (isLoading || !data || isAuthLoading) {
     return <LoadingScreen />
   }