From bfdf5548a08bf7a8af9db81a4de0bcb78ebf383a Mon Sep 17 00:00:00 2001 From: lebaudantoine Date: Tue, 9 Sep 2025 18:21:22 +0200 Subject: [PATCH] =?UTF-8?q?=F0=9F=94=A7(backend)=20rename=20OpenAI=20setti?= =?UTF-8?q?ngs=20to=20WhisperX=20to=20avoid=20confusion?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Rename incorrectly named OpenAI configuration settings since they're used to instantiate WhisperX client which is not OpenAI compatible, preventing confusion about actual service dependencies. --- env.d/development/summary.dist | 4 +++- src/helm/env.d/dev-dinum/values.meet.yaml.gotmpl | 14 ++++++-------- .../env.d/dev-keycloak/values.meet.yaml.gotmpl | 14 ++++++-------- src/helm/env.d/dev/values.meet.yaml.gotmpl | 14 ++++++-------- src/summary/summary/core/analytics.py | 2 +- src/summary/summary/core/celery_worker.py | 14 +++++++------- src/summary/summary/core/config.py | 8 ++++---- 7 files changed, 33 insertions(+), 37 deletions(-) diff --git a/env.d/development/summary.dist b/env.d/development/summary.dist index 47918313..6d8c4666 100644 --- a/env.d/development/summary.dist +++ b/env.d/development/summary.dist @@ -8,7 +8,9 @@ AWS_S3_SECURE_ACCESS=false AWS_S3_ACCESS_KEY_ID="meet" AWS_S3_SECRET_ACCESS_KEY="password" -OPENAI_API_KEY="your-openai-key" +WHISPERX_BASE_URL="https://configure-your-url.com" +WHISPERX_ASR_MODEL="large-v2" +WHISPERX_API_KEY="your-secret-key" WEBHOOK_API_TOKEN="secret" WEBHOOK_URL="https://configure-your-url.com" diff --git a/src/helm/env.d/dev-dinum/values.meet.yaml.gotmpl b/src/helm/env.d/dev-dinum/values.meet.yaml.gotmpl index 0684155c..94c09527 100644 --- a/src/helm/env.d/dev-dinum/values.meet.yaml.gotmpl +++ b/src/helm/env.d/dev-dinum/values.meet.yaml.gotmpl @@ -144,11 +144,10 @@ summary: AWS_S3_ENDPOINT_URL: minio.meet.svc.cluster.local:9000 AWS_S3_ACCESS_KEY_ID: meet AWS_S3_SECRET_ACCESS_KEY: password - OPENAI_API_KEY: password - OPENAI_BASE_URL: https://albertine.beta.numerique.gouv.fr/v1 - OPENAI_ASR_MODEL: large-v2 - OPENAI_LLM_MODEL: meta-llama/Llama-3.1-8B-Instruct AWS_S3_SECURE_ACCESS: False + WHISPERX_API_KEY: your-secret-value + WHISPERX_BASE_URL: https://configure-your-url.com + WHISPERX_ASR_MODEL: large-v2 WEBHOOK_API_TOKEN: password WEBHOOK_URL: https://www.mock-impress.com/webhook/ CELERY_BROKER_URL: redis://default:pass@redis-master:6379/1 @@ -177,11 +176,10 @@ celery: AWS_S3_ENDPOINT_URL: minio.meet.svc.cluster.local:9000 AWS_S3_ACCESS_KEY_ID: meet AWS_S3_SECRET_ACCESS_KEY: password - OPENAI_API_KEY: password - OPENAI_BASE_URL: https://albertine.beta.numerique.gouv.fr/v1 - OPENAI_ASR_MODEL: large-v2 - OPENAI_LLM_MODEL: meta-llama/Llama-3.1-8B-Instruct AWS_S3_SECURE_ACCESS: False + WHISPERX_API_KEY: your-secret-value + WHISPERX_BASE_URL: https://configure-your-url.com + WHISPERX_ASR_MODEL: large-v2 WEBHOOK_API_TOKEN: password WEBHOOK_URL: https://www.mock-impress.com/webhook/ CELERY_BROKER_URL: redis://default:pass@redis-master:6379/1 diff --git a/src/helm/env.d/dev-keycloak/values.meet.yaml.gotmpl b/src/helm/env.d/dev-keycloak/values.meet.yaml.gotmpl index 088c5d8b..2eec89fb 100644 --- a/src/helm/env.d/dev-keycloak/values.meet.yaml.gotmpl +++ b/src/helm/env.d/dev-keycloak/values.meet.yaml.gotmpl @@ -151,11 +151,10 @@ summary: AWS_S3_ENDPOINT_URL: minio.meet.svc.cluster.local:9000 AWS_S3_ACCESS_KEY_ID: meet AWS_S3_SECRET_ACCESS_KEY: password - OPENAI_API_KEY: password - OPENAI_BASE_URL: https://albertine.beta.numerique.gouv.fr/v1 - OPENAI_ASR_MODEL: large-v2 - OPENAI_LLM_MODEL: meta-llama/Llama-3.1-8B-Instruct AWS_S3_SECURE_ACCESS: False + WHISPERX_API_KEY: your-secret-value + WHISPERX_BASE_URL: https://configure-your-url.com + WHISPERX_ASR_MODEL: large-v2 WEBHOOK_API_TOKEN: password WEBHOOK_URL: https://www.mock-impress.com/webhook/ CELERY_BROKER_URL: redis://default:pass@redis-master:6379/1 @@ -185,11 +184,10 @@ celery: AWS_S3_ENDPOINT_URL: minio.meet.svc.cluster.local:9000 AWS_S3_ACCESS_KEY_ID: meet AWS_S3_SECRET_ACCESS_KEY: password - OPENAI_API_KEY: password - OPENAI_BASE_URL: https://albertine.beta.numerique.gouv.fr/v1 - OPENAI_ASR_MODEL: large-v2 - OPENAI_LLM_MODEL: meta-llama/Llama-3.1-8B-Instruct AWS_S3_SECURE_ACCESS: False + WHISPERX_API_KEY: your-secret-value + WHISPERX_BASE_URL: https://configure-your-url.com + WHISPERX_ASR_MODEL: large-v2 WEBHOOK_API_TOKEN: password WEBHOOK_URL: https://www.mock-impress.com/webhook/ CELERY_BROKER_URL: redis://default:pass@redis-master:6379/1 diff --git a/src/helm/env.d/dev/values.meet.yaml.gotmpl b/src/helm/env.d/dev/values.meet.yaml.gotmpl index 046c954c..89df9bb8 100644 --- a/src/helm/env.d/dev/values.meet.yaml.gotmpl +++ b/src/helm/env.d/dev/values.meet.yaml.gotmpl @@ -171,11 +171,10 @@ summary: AWS_S3_ENDPOINT_URL: minio.meet.svc.cluster.local:9000 AWS_S3_ACCESS_KEY_ID: meet AWS_S3_SECRET_ACCESS_KEY: password - OPENAI_API_KEY: password - OPENAI_BASE_URL: https://albertine.beta.numerique.gouv.fr/v1 - OPENAI_ASR_MODEL: openai/whisper-large-v3 - OPENAI_LLM_MODEL: meta-llama/Llama-3.1-8B-Instruct AWS_S3_SECURE_ACCESS: False + WHISPERX_API_KEY: your-secret-value + WHISPERX_BASE_URL: https://configure-your-url.com + WHISPERX_ASR_MODEL: large-v2 WEBHOOK_API_TOKEN: password WEBHOOK_URL: https://www.mock-impress.com/webhook/ CELERY_BROKER_URL: redis://default:pass@redis-master:6379/1 @@ -204,11 +203,10 @@ celery: AWS_S3_ENDPOINT_URL: minio.meet.svc.cluster.local:9000 AWS_S3_ACCESS_KEY_ID: meet AWS_S3_SECRET_ACCESS_KEY: password - OPENAI_API_KEY: password - OPENAI_BASE_URL: https://albertine.beta.numerique.gouv.fr/v1 - OPENAI_ASR_MODEL: openai/whisper-large-v3 - OPENAI_LLM_MODEL: meta-llama/Llama-3.1-8B-Instruct AWS_S3_SECURE_ACCESS: False + WHISPERX_API_KEY: your-secret-value + WHISPERX_BASE_URL: https://configure-your-url.com + WHISPERX_ASR_MODEL: large-v2 WEBHOOK_API_TOKEN: password WEBHOOK_URL: https://www.mock-impress.com/webhook/ CELERY_BROKER_URL: redis://default:pass@redis-master:6379/1 diff --git a/src/summary/summary/core/analytics.py b/src/summary/summary/core/analytics.py index 9b74d3e9..5286d907 100644 --- a/src/summary/summary/core/analytics.py +++ b/src/summary/summary/core/analytics.py @@ -114,7 +114,7 @@ class MetadataManager: initial_metadata = { "start_time": time.time(), - "asr_model": settings.openai_asr_model, + "asr_model": settings.whisperx_asr_model, "retries": 0, } diff --git a/src/summary/summary/core/celery_worker.py b/src/summary/summary/core/celery_worker.py index 0f97fc40..f5a1c22b 100644 --- a/src/summary/summary/core/celery_worker.py +++ b/src/summary/summary/core/celery_worker.py @@ -215,19 +215,19 @@ def process_audio_transcribe_summarize_v2( logger.error(error_msg) raise AudioValidationError(error_msg) - logger.info("Initiating OpenAI client") - openai_client = openai.OpenAI( - api_key=settings.openai_api_key, - base_url=settings.openai_base_url, - max_retries=settings.openai_max_retries, + logger.info("Initiating WhisperX client") + whisperx_client = openai.OpenAI( + api_key=settings.whisperx_api_key, + base_url=settings.whisperx_base_url, + max_retries=settings.whisperx_max_retries, ) try: logger.info("Querying transcription …") transcription_start_time = time.time() with open(temp_file_path, "rb") as audio_file: - transcription = openai_client.audio.transcriptions.create( - model=settings.openai_asr_model, file=audio_file + transcription = whisperx_client.audio.transcriptions.create( + model=settings.whisperx_asr_model, file=audio_file ) metadata_manager.track( task_id, diff --git a/src/summary/summary/core/config.py b/src/summary/summary/core/config.py index e2b24cc8..9b61be18 100644 --- a/src/summary/summary/core/config.py +++ b/src/summary/summary/core/config.py @@ -32,10 +32,10 @@ class Settings(BaseSettings): aws_s3_secure_access: bool = True # AI-related settings - openai_api_key: str - openai_base_url: str = "https://api.openai.com/v1" - openai_asr_model: str = "whisper-1" - openai_max_retries: int = 0 + whisperx_api_key: str + whisperx_base_url: str = "https://api.openai.com/v1" + whisperx_asr_model: str = "whisper-1" + whisperx_max_retries: int = 0 # Webhook-related settings webhook_max_retries: int = 2