From c8772bb1ad9b9df97416a48c182b05518c24d39d Mon Sep 17 00:00:00 2001 From: lebaudantoine Date: Mon, 19 May 2025 11:09:21 +0200 Subject: [PATCH] =?UTF-8?q?=F0=9F=90=9B(backend)=20update=20pin=20code=20t?= =?UTF-8?q?ests=20after=20increasing=20max=20retry=20limit?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fix test cases for room PIN code generation that were not updated when max retry limit was increased during code review. Aligns test expectations with actual implementation to prevent false failures. --- src/backend/core/tests/test_models_rooms.py | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/backend/core/tests/test_models_rooms.py b/src/backend/core/tests/test_models_rooms.py index 2117ada7..3cc8acbb 100644 --- a/src/backend/core/tests/test_models_rooms.py +++ b/src/backend/core/tests/test_models_rooms.py @@ -302,25 +302,25 @@ def test_pin_generation_max_retries(mock_randbelow, mock_logger, settings): RoomFactory(pin_code="12345") - # Assert default max retries is low, 3 + # Assert default max retries is low, 5 room1 = RoomFactory() - assert mock_randbelow.call_count == 3 + assert mock_randbelow.call_count == 5 assert room1.pin_code is None mock_logger.assert_called_once_with( - "Failed to generate unique PIN code of length %s after %s attempts", 5, 3 + "Failed to generate unique PIN code of length %s after %s attempts", 5, 5 ) mock_logger.reset_mock() mock_randbelow.reset_mock() - settings.ROOM_TELEPHONY_PIN_MAX_RETRIES = 5 + settings.ROOM_TELEPHONY_PIN_MAX_RETRIES = 3 room2 = RoomFactory() - assert mock_randbelow.call_count == 5 + assert mock_randbelow.call_count == 3 assert room2.pin_code is None mock_logger.assert_called_once_with( - "Failed to generate unique PIN code of length %s after %s attempts", 5, 5 + "Failed to generate unique PIN code of length %s after %s attempts", 5, 3 )