studio/meet
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

⚡️(frontend) avoid non-primitive default props recreation on each render

Browse Source 
The empty object literal created a new reference every render,
potentially triggering unnecessary re-renders.

Hoist an EMPTY_PROPS constant to the module level and reuse it
instead of allocating a new object.
This commit is contained in:
lebaudantoine
2026-03-03 19:34:20 +01:00
committed by aleb_the_flash
parent 6e3845d0c1
commit ca9c7fc152
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/frontend/src/features/settings/components/tabs/VideoTab.tsx
View File

@@ -22,6 +22,8 @@ export type VideoTabProps = Pick<DialogProps, 'onOpenChange'> &
type DeviceItems = Array<{ value: string; label: string }> type DeviceItems = Array<{ value: string; label: string }>
const EMPTY_PROPS = {}
export const VideoTab = ({ id }: VideoTabProps) => { export const VideoTab = ({ id }: VideoTabProps) => {
const { t } = useTranslation('settings', { keyPrefix: 'video' }) const { t } = useTranslation('settings', { keyPrefix: 'video' })
const { localParticipant, remoteParticipants } = useRoomContext() const { localParticipant, remoteParticipants } = useRoomContext()
@@ -59,7 +61,7 @@ export const VideoTab = ({ id }: VideoTabProps) => {
const isCamEnabled = devicesIn?.length > 0 const isCamEnabled = devicesIn?.length > 0
const disabledProps = isCamEnabled const disabledProps = isCamEnabled
? {} ? EMPTY_PROPS
: { : {
placeholder: t('permissionsRequired'), placeholder: t('permissionsRequired'),
isDisabled: true, isDisabled: true,