From d9a84e5f0fd7d1372595029483d82a20bfa85c84 Mon Sep 17 00:00:00 2001 From: lebaudantoine Date: Wed, 4 Dec 2024 11:31:47 +0100 Subject: [PATCH] =?UTF-8?q?=F0=9F=94=A5(frontend)=20remove=20transcription?= =?UTF-8?q?=20menu=20item?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This menu item was replaced by a side panel. --- .../controls/Options/OptionsMenuItems.tsx | 2 - .../controls/Options/TranscriptMenuItem.tsx | 71 ------------------- src/frontend/src/locales/de/rooms.json | 6 +- src/frontend/src/locales/en/rooms.json | 6 +- src/frontend/src/locales/fr/rooms.json | 6 +- 5 files changed, 3 insertions(+), 88 deletions(-) delete mode 100644 src/frontend/src/features/rooms/livekit/components/controls/Options/TranscriptMenuItem.tsx diff --git a/src/frontend/src/features/rooms/livekit/components/controls/Options/OptionsMenuItems.tsx b/src/frontend/src/features/rooms/livekit/components/controls/Options/OptionsMenuItems.tsx index 8e36b030..72f5fc54 100644 --- a/src/frontend/src/features/rooms/livekit/components/controls/Options/OptionsMenuItems.tsx +++ b/src/frontend/src/features/rooms/livekit/components/controls/Options/OptionsMenuItems.tsx @@ -10,7 +10,6 @@ import { DialogState } from './OptionsButton' import { Separator } from '@/primitives/Separator' import { useSidePanel } from '../../../hooks/useSidePanel' import { menuRecipe } from '@/primitives/menuRecipe.ts' -import { TranscriptMenuItem } from './TranscriptMenuItem' // @todo try refactoring it to use MenuList component export const OptionsMenuItems = ({ @@ -35,7 +34,6 @@ export const OptionsMenuItems = ({ {t('effects')} -
diff --git a/src/frontend/src/features/rooms/livekit/components/controls/Options/TranscriptMenuItem.tsx b/src/frontend/src/features/rooms/livekit/components/controls/Options/TranscriptMenuItem.tsx deleted file mode 100644 index 856511ed..00000000 --- a/src/frontend/src/features/rooms/livekit/components/controls/Options/TranscriptMenuItem.tsx +++ /dev/null @@ -1,71 +0,0 @@ -import { RiRecordCircleLine, RiStopCircleLine } from '@remixicon/react' -import { useTranslation } from 'react-i18next' -import { menuRecipe } from '@/primitives/menuRecipe' -import { MenuItem } from 'react-aria-components' -import { - RecordingMode, - useStartRecording, -} from '@/features/rooms/api/startRecording' -import { useStopRecording } from '@/features/rooms/api/stopRecording' -import { useRoomContext } from '@livekit/components-react' -import { useRoomData } from '@/features/rooms/livekit/hooks/useRoomData' -import { useConfig } from '@/api/useConfig' - -export const TranscriptMenuItem = () => { - const { t } = useTranslation('rooms', { keyPrefix: 'options.items' }) - - const apiRoomData = useRoomData() - - const { mutateAsync: startRecordingRoom } = useStartRecording() - const { mutateAsync: stopRecordingRoom } = useStopRecording() - - const { data } = useConfig() - - const room = useRoomContext() - - const handleTranscript = async () => { - const roomId = apiRoomData?.livekit?.room - - if (!roomId) { - console.warn('No room ID found') - return - } - - try { - if (room.isRecording) { - await stopRecordingRoom({ id: roomId }) - } else { - await startRecordingRoom({ id: roomId, mode: RecordingMode.Transcript }) - } - } catch (error) { - console.error('Failed to handle transcript:', error) - } - } - - if ( - !data?.recording?.is_enabled || - !data?.recording?.available_modes?.includes(RecordingMode.Transcript) || - !apiRoomData?.is_administrable - ) { - return - } - - return ( - await handleTranscript()} - > - {room.isRecording ? ( - <> - - {t('transcript.stop')} - - ) : ( - <> - - {t('transcript.start')} - - )} - - ) -} diff --git a/src/frontend/src/locales/de/rooms.json b/src/frontend/src/locales/de/rooms.json index e86c4794..d898b402 100644 --- a/src/frontend/src/locales/de/rooms.json +++ b/src/frontend/src/locales/de/rooms.json @@ -83,11 +83,7 @@ "feedbacks": "", "settings": "", "username": "", - "effects": "", - "transcript": { - "start": "", - "stop": "" - } + "effects": "" } }, "effects": { diff --git a/src/frontend/src/locales/en/rooms.json b/src/frontend/src/locales/en/rooms.json index 2db4ed33..17cc40da 100644 --- a/src/frontend/src/locales/en/rooms.json +++ b/src/frontend/src/locales/en/rooms.json @@ -82,11 +82,7 @@ "feedbacks": "Give us feedbacks", "settings": "Settings", "username": "Update Your Name", - "effects": "Apply effects", - "transcript": { - "start": "Start meeting transcription", - "stop": "Stop ongoing transcription" - } + "effects": "Apply effects" } }, "effects": { diff --git a/src/frontend/src/locales/fr/rooms.json b/src/frontend/src/locales/fr/rooms.json index 6c2edbda..3429a916 100644 --- a/src/frontend/src/locales/fr/rooms.json +++ b/src/frontend/src/locales/fr/rooms.json @@ -82,11 +82,7 @@ "feedbacks": "Partager votre avis", "settings": "Paramètres", "username": "Choisir votre nom", - "effects": "Appliquer des effets", - "transcript": { - "start": "Démarrer la transcription", - "stop": "Arrêter la transcription en cours" - } + "effects": "Appliquer des effets" } }, "effects": {