From ee1abbed04929926adedbab51770eb2d4e0a7ab6 Mon Sep 17 00:00:00 2001 From: Emmanuel Pelletier Date: Mon, 29 Jul 2024 08:42:06 +0200 Subject: [PATCH] =?UTF-8?q?=F0=9F=9A=B8(feedback)=20remember=20the=20user?= =?UTF-8?q?=20about=20feedback=20form=20on=20call=20end?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit add a new route that just tells the user about the feedback form --- .../features/rooms/components/Conference.tsx | 2 +- src/frontend/src/features/rooms/index.ts | 1 + .../src/features/rooms/routes/Feedback.tsx | 19 +++++++++++++++++++ src/frontend/src/locales/de/rooms.json | 4 ++++ src/frontend/src/locales/en/rooms.json | 4 ++++ src/frontend/src/locales/fr/rooms.json | 4 ++++ src/frontend/src/routes.ts | 9 +++++++-- 7 files changed, 40 insertions(+), 3 deletions(-) create mode 100644 src/frontend/src/features/rooms/routes/Feedback.tsx diff --git a/src/frontend/src/features/rooms/components/Conference.tsx b/src/frontend/src/features/rooms/components/Conference.tsx index 86e0b6ff..2bdcae21 100644 --- a/src/frontend/src/features/rooms/components/Conference.tsx +++ b/src/frontend/src/features/rooms/components/Conference.tsx @@ -56,7 +56,7 @@ export const Conference = ({ audio={userConfig.audioEnabled} video={userConfig.videoEnabled} onDisconnected={() => { - navigateTo('home') + navigateTo('feedback') }} > diff --git a/src/frontend/src/features/rooms/index.ts b/src/frontend/src/features/rooms/index.ts index cd686866..c7027155 100644 --- a/src/frontend/src/features/rooms/index.ts +++ b/src/frontend/src/features/rooms/index.ts @@ -1,3 +1,4 @@ export { Room as RoomRoute } from './routes/Room' +export { FeedbackRoute } from './routes/Feedback' export { roomIdPattern, isRoomValid } from './utils/isRoomValid' export { generateRoomId } from './utils/generateRoomId' diff --git a/src/frontend/src/features/rooms/routes/Feedback.tsx b/src/frontend/src/features/rooms/routes/Feedback.tsx new file mode 100644 index 00000000..468c73fb --- /dev/null +++ b/src/frontend/src/features/rooms/routes/Feedback.tsx @@ -0,0 +1,19 @@ +import { useTranslation } from 'react-i18next' +import { BoxScreen } from '@/layout/BoxScreen' +import { Div, Link, P } from '@/primitives' + +export const FeedbackRoute = () => { + const { t } = useTranslation('rooms') + return ( + +
+

{t('feedback.body')}

+
+
+

+ {t('backToHome', { ns: 'global' })} +

+
+
+ ) +} diff --git a/src/frontend/src/locales/de/rooms.json b/src/frontend/src/locales/de/rooms.json index 768d0e4f..827035f3 100644 --- a/src/frontend/src/locales/de/rooms.json +++ b/src/frontend/src/locales/de/rooms.json @@ -1,4 +1,8 @@ { + "feedback": { + "body": "", + "heading": "" + }, "join": { "camlabel": "", "heading": "", diff --git a/src/frontend/src/locales/en/rooms.json b/src/frontend/src/locales/en/rooms.json index a8a3d1ca..00f3d6fe 100644 --- a/src/frontend/src/locales/en/rooms.json +++ b/src/frontend/src/locales/en/rooms.json @@ -1,4 +1,8 @@ { + "feedback": { + "body": "Please fill out the form available in the header to give us your precious feedback! Thanks.", + "heading": "Help us improve Meet" + }, "join": { "camlabel": "Camera", "heading": "Join the meeting", diff --git a/src/frontend/src/locales/fr/rooms.json b/src/frontend/src/locales/fr/rooms.json index e03bfa1d..524a57f2 100644 --- a/src/frontend/src/locales/fr/rooms.json +++ b/src/frontend/src/locales/fr/rooms.json @@ -1,4 +1,8 @@ { + "feedback": { + "body": "Remplissez le formulaire disponible dans l'entête du site pour nous donner votre avis sur l'outil. Vos retours sont précieux ! Merci.", + "heading": "Aidez-nous à améliorer Meet" + }, "join": { "camlabel": "Webcam", "heading": "Rejoindre la réunion", diff --git a/src/frontend/src/routes.ts b/src/frontend/src/routes.ts index ba7f7e0d..4de742bc 100644 --- a/src/frontend/src/routes.ts +++ b/src/frontend/src/routes.ts @@ -1,8 +1,8 @@ -import { RoomRoute, roomIdPattern } from '@/features/rooms' +import { FeedbackRoute, RoomRoute, roomIdPattern } from '@/features/rooms' import { HomeRoute } from '@/features/home' export const routes: Record< - 'home' | 'room', + 'home' | 'room' | 'feedback', { name: RouteName path: RegExp | string @@ -22,6 +22,11 @@ export const routes: Record< to: (roomId: string) => `/${roomId.trim()}`, Component: RoomRoute, }, + feedback: { + name: 'feedback', + path: '/feedback', + Component: FeedbackRoute, + }, } export type RouteName = keyof typeof routes