From 227ecd0700e8df573bf7beb6977064731e79850f Mon Sep 17 00:00:00 2001 From: Marie PUPO JEAMMET Date: Wed, 22 Jan 2025 17:08:53 +0100 Subject: [PATCH] =?UTF-8?q?=F0=9F=90=9B(dimail)=20fix=20imported=20mailbox?= =?UTF-8?q?es=20should=20be=20enabled=20instead=20of=20pending?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Importing mailboxes creates pending mailboxes ... but these mailboxes are already active and, for most, functional. We thus mark them as "enabled". --- CHANGELOG.md | 1 + .../mailbox_manager/tests/test_utils_dimail_client.py | 1 + src/backend/mailbox_manager/utils/dimail.py | 6 +++--- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 6d128a0..96dd4b5 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -18,6 +18,7 @@ and this project adheres to ### Fixed +- 🐛(dimail) fix imported mailboxes should be enabled instead of pending #659 - ⚡️(api) add missing cache for stats endpoint ## [1.10.0] - 2025-01-21 diff --git a/src/backend/mailbox_manager/tests/test_utils_dimail_client.py b/src/backend/mailbox_manager/tests/test_utils_dimail_client.py index 7a60dfd..6493710 100644 --- a/src/backend/mailbox_manager/tests/test_utils_dimail_client.py +++ b/src/backend/mailbox_manager/tests/test_utils_dimail_client.py @@ -156,6 +156,7 @@ def test_dimail_synchronization__synchronize_mailboxes(mock_warning): mailbox = models.Mailbox.objects.get() assert mailbox.local_part == "oxadmin" + assert mailbox.status == enums.MailboxStatusChoices.ENABLED assert imported_mailboxes == [mailbox_valid["email"]] diff --git a/src/backend/mailbox_manager/utils/dimail.py b/src/backend/mailbox_manager/utils/dimail.py index f7bde05..d2c2f08 100644 --- a/src/backend/mailbox_manager/utils/dimail.py +++ b/src/backend/mailbox_manager/utils/dimail.py @@ -337,10 +337,10 @@ class DimailAPIClient: last_name=dimail_mailbox["surName"], local_part=address.username, domain=domain, - secondary_email=dimail_mailbox[ - "email" - ], # secondary email is mandatory. Unfortunately, dimail doesn't + secondary_email=dimail_mailbox["email"], + # secondary email is mandatory. Unfortunately, dimail doesn't # store any. We temporarily give current email as secondary email. + status=enums.MailboxStatusChoices.ENABLED, ) imported_mailboxes.append(str(mailbox)) else: