🔥(sops) remove obsolete sops file

remove obsolete sops file

src/backend/mailbox_manager/tests/api/aliases/test_api_aliases_create.py

@@ -1,7 +1,8 @@
 """
-Tests for mailbox Aliases API endpoint in People's app mailbox_manager.
+Tests for aliases API endpoint.
 Focus on "create" action.
 """
+# pylint: disable=W0613
 
 import json
 import re
@@ -14,7 +15,6 @@ from rest_framework.test import APIClient
 from core import factories as core_factories
 
 from mailbox_manager import enums, factories, models
-from mailbox_manager.tests.fixtures.dimail import TOKEN_OK
 
 pytestmark = pytest.mark.django_db
 
@@ -80,7 +80,7 @@ def test_api_aliases_create__duplicate_forbidden():
     assert models.Alias.objects.filter(domain=access.domain).count() == 1
 
 
-def test_api_aliases_create__existing_mailbox_bad_request():
+def test_api_aliases_create__existing_alias_bad_request():
     """Cannot create alias if local_part is already used by a mailbox."""
     access = factories.MailDomainAccessFactory(
         role="owner", domain=factories.MailDomainEnabledFactory()
@@ -94,6 +94,46 @@ def test_api_aliases_create__existing_mailbox_bad_request():
         {"local_part": mailbox.local_part, "destination": "someone@outsidedomain.com"},
     )
     assert response.status_code == status.HTTP_400_BAD_REQUEST
+    assert response.json() == {
+        "local_part": [f'Local part "{mailbox.local_part}" already used for a mailbox.']
+    }
+    assert not models.Alias.objects.exists()
+
+
+@responses.activate
+def test_api_aliases_create__async_alias_bad_request(dimail_token_ok):
+    """
+    If People fall out of sync with dimail, return a clear error if alias cannot be created
+    because it already exists on dimail.
+    """
+    access = factories.MailDomainAccessFactory(
+        role="owner", domain=factories.MailDomainEnabledFactory()
+    )
+
+    client = APIClient()
+    client.force_login(access.user)
+    # Mock dimail response
+    responses.add(
+        responses.POST,
+        re.compile(r".*/aliases/"),
+        body=json.dumps({"detail": "Alias already exists"}),
+        status=status.HTTP_409_CONFLICT,
+        content_type="application/json",
+    )
+
+    response = client.post(
+        f"/api/v1.0/mail-domains/{access.domain.slug}/aliases/",
+        {
+            "local_part": "already_existing_alias",
+            "destination": "someone@outsidedomain.com",
+        },
+    )
+    assert response.status_code == status.HTTP_400_BAD_REQUEST
+    assert response.json() == {
+        "NON_FIELD_ERRORS": [
+            "Alias already exists. Your domain is out of sync, please contact our support."
+        ]
+    }
     assert not models.Alias.objects.exists()
 
 
@@ -102,20 +142,14 @@ def test_api_aliases_create__existing_mailbox_bad_request():
     "role",
     [enums.MailDomainRoleChoices.OWNER, enums.MailDomainRoleChoices.ADMIN],
 )
-def test_api_aliases_create__admins_ok(role):
+def test_api_aliases_create__admins_ok(role, dimail_token_ok):
     """Domain admins should be able to create aliases."""
     access = factories.MailDomainAccessFactory(role=role)
 
     client = APIClient()
     client.force_login(access.user)
     # Prepare responses
-    responses.add(
-        responses.GET,
-        re.compile(r".*/token/"),
-        body=TOKEN_OK,
-        status=status.HTTP_200_OK,
-        content_type="application/json",
-    )
+    # token response in fixtures
     responses.add(
         responses.POST,
         re.compile(rf".*/domains/{access.domain.name}/aliases/"),

src/backend/mailbox_manager/tests/api/aliases/test_api_aliases_delete.py

@@ -45,21 +45,63 @@ def test_api_aliases_delete__no_access_forbidden():
 
 def test_api_aliases_delete__viewer_forbidden():
     """
-    Authenticated users should not be allowed to delete a mail domain access for a
+    Authenticated users should not be allowed to delete aliases for a
     mail domain in which they are a simple viewer.
     """
     authenticated_user = core_factories.UserFactory()
     mail_domain = factories.MailDomainFactory(
         users=[(authenticated_user, enums.MailDomainRoleChoices.VIEWER)]
     )
-    access = factories.MailDomainAccessFactory(domain=mail_domain)
+    alias = factories.AliasFactory(domain=mail_domain)
 
     client = APIClient()
     client.force_login(authenticated_user)
     response = client.delete(
-        f"/api/v1.0/mail-domains/{mail_domain.slug}/accesses/{access.id!s}/",
+        f"/api/v1.0/mail-domains/{mail_domain.slug}/aliases/{alias.local_part}/",
     )
 
     assert response.status_code == status.HTTP_403_FORBIDDEN
-    assert models.MailDomainAccess.objects.count() == 2
-    assert models.MailDomainAccess.objects.filter(user=access.user).exists()
+    assert models.Alias.objects.count() == 1
+
+
+def test_api_aliases_delete__viewer_can_delete_self_alias():
+    """
+    Authenticated users should be allowed to delete aliases when linking
+    to their own mailbox.
+    """
+    authenticated_user = core_factories.UserFactory()
+    mail_domain = factories.MailDomainFactory(
+        users=[(authenticated_user, enums.MailDomainRoleChoices.VIEWER)]
+    )
+    alias = factories.AliasFactory(
+        domain=mail_domain, destination=authenticated_user.email
+    )
+
+    client = APIClient()
+    client.force_login(authenticated_user)
+    response = client.delete(
+        f"/api/v1.0/mail-domains/{mail_domain.slug}/aliases/{alias.local_part}/",
+    )
+
+    assert response.status_code == status.HTTP_204_NO_CONTENT
+    assert not models.Alias.objects.exists()
+
+
+def test_api_aliases_delete__administrators_allowed():
+    """
+    Administrators of a mail domain should be allowed to delete accesses excepted owner accesses.
+    """
+    authenticated_user = core_factories.UserFactory()
+    mail_domain = factories.MailDomainFactory(
+        users=[(authenticated_user, enums.MailDomainRoleChoices.ADMIN)]
+    )
+    alias = factories.AliasFactory(domain=mail_domain)
+
+    client = APIClient()
+    client.force_login(authenticated_user)
+    response = client.delete(
+        f"/api/v1.0/mail-domains/{mail_domain.slug}/aliases/{alias.local_part}/",
+    )
+
+    assert response.status_code == status.HTTP_204_NO_CONTENT
+    assert not models.Alias.objects.exists()