From 340ddf8b1a70682b19a8fc4815c9469b5d93f577 Mon Sep 17 00:00:00 2001
From: Marie PUPO JEAMMET <marie.jeammet@beta.gouv.fr>
Date: Thu, 21 Mar 2024 14:56:55 +0100
Subject: [PATCH] =?UTF-8?q?=F0=9F=90=9B(dependencies)=20modify=20expected?=
 =?UTF-8?q?=20details=20on=20404=20responses?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

djangorestframework released version 3.15.0, which includes modifications of
details upon returning 404 errors (see related issue
https://github.com/encode/django-rest-framework/pull/8051).

This commit changes the expected details of 404 responses in our tests,
to match DRF 3.15.0.
---
 .../tests/team_accesses/test_api_team_accesses_retrieve.py    | 4 ++--
 src/backend/core/tests/teams/test_core_api_teams_delete.py    | 2 +-
 src/backend/core/tests/teams/test_core_api_teams_retrieve.py  | 2 +-
 src/backend/core/tests/teams/test_core_api_teams_update.py    | 4 ++--
 4 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/backend/core/tests/team_accesses/test_api_team_accesses_retrieve.py b/src/backend/core/tests/team_accesses/test_api_team_accesses_retrieve.py
index 3c28fb0..ee6d4e8 100644
--- a/src/backend/core/tests/team_accesses/test_api_team_accesses_retrieve.py
+++ b/src/backend/core/tests/team_accesses/test_api_team_accesses_retrieve.py
@@ -42,7 +42,7 @@ def test_api_team_accesses_retrieve_authenticated_unrelated():
         f"/api/v1.0/teams/{access.team.id!s}/accesses/{access.id!s}/",
     )
     assert response.status_code == 404
-    assert response.json() == {"detail": "Not found."}
+    assert response.json() == {"detail": "No TeamAccess matches the given query."}
 
     # Accesses related to another team should be excluded even if the user is related to it
     for other_access in [
@@ -54,7 +54,7 @@ def test_api_team_accesses_retrieve_authenticated_unrelated():
         )
 
         assert response.status_code == 404
-        assert response.json() == {"detail": "Not found."}
+        assert response.json() == {"detail": "No TeamAccess matches the given query."}
 
 
 def test_api_team_accesses_retrieve_authenticated_related():
diff --git a/src/backend/core/tests/teams/test_core_api_teams_delete.py b/src/backend/core/tests/teams/test_core_api_teams_delete.py
index 9017509..861e6fa 100644
--- a/src/backend/core/tests/teams/test_core_api_teams_delete.py
+++ b/src/backend/core/tests/teams/test_core_api_teams_delete.py
@@ -45,7 +45,7 @@ def test_api_teams_delete_authenticated_unrelated():
     )
 
     assert response.status_code == HTTP_404_NOT_FOUND
-    assert response.json() == {"detail": "Not found."}
+    assert response.json() == {"detail": "No Team matches the given query."}
     assert models.Team.objects.count() == 1
 
 
diff --git a/src/backend/core/tests/teams/test_core_api_teams_retrieve.py b/src/backend/core/tests/teams/test_core_api_teams_retrieve.py
index 36eedea..1fdb62c 100644
--- a/src/backend/core/tests/teams/test_core_api_teams_retrieve.py
+++ b/src/backend/core/tests/teams/test_core_api_teams_retrieve.py
@@ -38,7 +38,7 @@ def test_api_teams_retrieve_authenticated_unrelated():
         f"/api/v1.0/teams/{team.id!s}/",
     )
     assert response.status_code == HTTP_404_NOT_FOUND
-    assert response.json() == {"detail": "Not found."}
+    assert response.json() == {"detail": "No Team matches the given query."}
 
 
 def test_api_teams_retrieve_authenticated_related():
diff --git a/src/backend/core/tests/teams/test_core_api_teams_update.py b/src/backend/core/tests/teams/test_core_api_teams_update.py
index 64f0d55..60c8610 100644
--- a/src/backend/core/tests/teams/test_core_api_teams_update.py
+++ b/src/backend/core/tests/teams/test_core_api_teams_update.py
@@ -61,7 +61,7 @@ def test_api_teams_update_authenticated_unrelated():
     )
 
     assert response.status_code == HTTP_404_NOT_FOUND
-    assert response.json() == {"detail": "Not found."}
+    assert response.json() == {"detail": "No Team matches the given query."}
 
     team.refresh_from_db()
     team_values = serializers.TeamSerializer(instance=team).data
@@ -188,7 +188,7 @@ def test_api_teams_update_administrator_or_owner_of_another():
     )
 
     assert response.status_code == HTTP_404_NOT_FOUND
-    assert response.json() == {"detail": "Not found."}
+    assert response.json() == {"detail": "No Team matches the given query."}
 
     team.refresh_from_db()
     team_values = serializers.TeamSerializer(instance=team).data