From 43d802a73bf5d0f3cdfa169fcac8b79a10890d4b Mon Sep 17 00:00:00 2001 From: Lebaud Antoine Date: Thu, 7 Mar 2024 09:38:59 +0100 Subject: [PATCH] =?UTF-8?q?=F0=9F=8E=A8(backend)=20early=20return=20in=20U?= =?UTF-8?q?ser=20factory?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Avoid unnecessary nesting when code can early return. Also, rename "item" to a more explicit name "user_entry". it's very nit-picking, sorry. --- src/backend/core/factories.py | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/src/backend/core/factories.py b/src/backend/core/factories.py index 131196d..8b5035d 100644 --- a/src/backend/core/factories.py +++ b/src/backend/core/factories.py @@ -155,12 +155,13 @@ class TeamFactory(factory.django.DjangoModelFactory): @factory.post_generation def users(self, create, extracted, **kwargs): """Add users to team from a given list of users with or without roles.""" - if create and extracted: - for item in extracted: - if isinstance(item, models.User): - TeamAccessFactory(team=self, user=item) - else: - TeamAccessFactory(team=self, user=item[0], role=item[1]) + if not create or not extracted: + return + for user_entry in extracted: + if isinstance(user_entry, models.User): + TeamAccessFactory(team=self, user=user_entry) + else: + TeamAccessFactory(team=self, user=user_entry[0], role=user_entry[1]) class TeamAccessFactory(factory.django.DjangoModelFactory):