From 4a08a9ec92dfd90f3b21dd9815c592799969abf0 Mon Sep 17 00:00:00 2001
From: Quentin BEY <quentin.bey@mail.numerique.gouv.fr>
Date: Tue, 6 May 2025 10:27:28 +0200
Subject: [PATCH] =?UTF-8?q?=E2=9A=B0=EF=B8=8F(front)=20remove=20unused=20c?=
 =?UTF-8?q?ode=20after=20UI=20v2?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The linter was unhappy, so I removed the unused variables or code.
---
 .../apps/e2e/__tests__/app-desk/header.spec.ts |  2 +-
 .../mail-domain-create-mailbox.spec.ts         | 18 +++++++-----------
 .../__tests__/app-desk/mail-domains.spec.ts    |  2 +-
 3 files changed, 9 insertions(+), 13 deletions(-)

diff --git a/src/frontend/apps/e2e/__tests__/app-desk/header.spec.ts b/src/frontend/apps/e2e/__tests__/app-desk/header.spec.ts
index 868c2bb..551d776 100644
--- a/src/frontend/apps/e2e/__tests__/app-desk/header.spec.ts
+++ b/src/frontend/apps/e2e/__tests__/app-desk/header.spec.ts
@@ -8,7 +8,7 @@ test.beforeEach(async ({ page, browserName }) => {
 });
 
 test.describe('Header', () => {
-  test('checks all the elements are visible', async ({ page, browserName }) => {
+  test('checks all the elements are visible', async ({ page }) => {
     const header = page.locator('header').first();
 
     await expect(header.getByText('La Régie')).toBeVisible();
diff --git a/src/frontend/apps/e2e/__tests__/app-desk/mail-domain-create-mailbox.spec.ts b/src/frontend/apps/e2e/__tests__/app-desk/mail-domain-create-mailbox.spec.ts
index 3bb4b77..c99ef17 100644
--- a/src/frontend/apps/e2e/__tests__/app-desk/mail-domain-create-mailbox.spec.ts
+++ b/src/frontend/apps/e2e/__tests__/app-desk/mail-domain-create-mailbox.spec.ts
@@ -14,6 +14,7 @@ const mailDomainsFixtures: MailDomain[] = [
     updated_at: currentDateIso,
     slug: 'domainfr',
     status: 'enabled',
+    support_email: 'support@domain.fr',
     abilities: {
       get: true,
       patch: true,
@@ -30,6 +31,7 @@ const mailDomainsFixtures: MailDomain[] = [
     updated_at: currentDateIso,
     slug: 'mailsfr',
     status: 'enabled',
+    support_email: 'support@mails.fr',
     abilities: {
       get: true,
       patch: true,
@@ -46,6 +48,7 @@ const mailDomainsFixtures: MailDomain[] = [
     updated_at: currentDateIso,
     slug: 'versaillesnet',
     status: 'enabled',
+    support_email: 'support@versailles.net',
     abilities: {
       get: true,
       patch: true,
@@ -62,6 +65,7 @@ const mailDomainsFixtures: MailDomain[] = [
     updated_at: currentDateIso,
     slug: 'parisfr',
     status: 'enabled',
+    support_email: 'support@paris.fr',
     abilities: {
       get: true,
       patch: true,
@@ -134,14 +138,6 @@ const interceptCommonApiRequests = async (
   );
 };
 
-const navigateToMailboxCreationFormForMailDomainFr = async (
-  page: Page,
-): Promise<void> => {
-  await page.goto('/mail-domains');
-  await page.getByLabel(`domain.fr listboxDomains button`).click();
-  await page.getByRole('button', { name: 'New mail address' }).click();
-};
-
 test.describe('Mail domain create mailbox', () => {
   test('checks user can New mail address when he has post ability', async ({
     page,
@@ -205,6 +201,8 @@ test.describe('Mail domain create mailbox', () => {
       }
     });
 
+    await interceptRequests(page);
+
     await page.goto('/');
     // Login with a user who has the visibility on the mail domains
     await keyCloakSignIn(page, browserName, 'mail-member');
@@ -213,9 +211,7 @@ test.describe('Mail domain create mailbox', () => {
 
     await page.getByLabel(`domain.fr listboxDomains button`).click();
 
-    await expect(
-      page.getByRole('button', { name: 'New mail address' }),
-    ).click();
+    await page.getByTestId('button-new-mailbox').click();
 
     await expect(page.getByText('New email account')).toBeVisible();
 
diff --git a/src/frontend/apps/e2e/__tests__/app-desk/mail-domains.spec.ts b/src/frontend/apps/e2e/__tests__/app-desk/mail-domains.spec.ts
index c8f6a9c..12d49c0 100644
--- a/src/frontend/apps/e2e/__tests__/app-desk/mail-domains.spec.ts
+++ b/src/frontend/apps/e2e/__tests__/app-desk/mail-domains.spec.ts
@@ -131,7 +131,7 @@ test.describe('Mail domains', () => {
       await expect(page.getByText('Manage')).toHaveCount(4);
 
       await Promise.all(
-        mailDomainsFixtures.map(async ({ name, status }) => {
+        mailDomainsFixtures.map(async ({ name }) => {
           const linkName = page.getByText(name);
           await expect(linkName).toBeVisible();
         }),