From 666cafe220a2875518cc5fc522b4a128ad2290bd Mon Sep 17 00:00:00 2001
From: Sabrina Demagny <sabrina.demagny@gmail.com>
Date: Tue, 18 Mar 2025 15:40:46 +0100
Subject: [PATCH] =?UTF-8?q?=F0=9F=93=9D(dimail)=20add=20some=20info=20abou?=
 =?UTF-8?q?t=20data=20required=20to=20create=20mailbox?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Prepare generic mailbox implementation
---
 src/backend/mailbox_manager/utils/dimail.py | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/backend/mailbox_manager/utils/dimail.py b/src/backend/mailbox_manager/utils/dimail.py
index fbe85ab..fb15111 100644
--- a/src/backend/mailbox_manager/utils/dimail.py
+++ b/src/backend/mailbox_manager/utils/dimail.py
@@ -119,8 +119,11 @@ class DimailAPIClient:
         """Send a CREATE mailbox request to mail provisioning API."""
 
         payload = {
+            # givenName value can be empty
             "givenName": mailbox.first_name,
+            # surName value can be empty
             "surName": mailbox.last_name,
+            # displayName value has to be unique
             "displayName": f"{mailbox.first_name} {mailbox.last_name}",
         }
         headers = self.get_headers(user_sub)