From 72340db74cd275b683277cd555ce8080463f9097 Mon Sep 17 00:00:00 2001 From: daproclaima Date: Thu, 18 Jul 2024 15:09:31 +0200 Subject: [PATCH] =?UTF-8?q?=F0=9F=92=AC(frontend)=20update=20texts?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - change message showed in mailbox list when none exist - change CTA button text for group management modals - fix 404 page title - update translations - update related e2e tests --- .../mail-domains/components/MailDomainsContent.tsx | 4 ++++ .../teams/member-add/components/ModalAddMembers.tsx | 2 +- .../teams/member-management/components/ModalDelete.tsx | 2 +- src/frontend/apps/desk/src/i18n/translations.json | 7 +++++-- src/frontend/apps/desk/src/pages/404.tsx | 2 +- .../apps/e2e/__tests__/app-desk/mail-domain.spec.ts | 4 +++- src/frontend/apps/e2e/__tests__/app-desk/team.spec.ts | 1 + 7 files changed, 16 insertions(+), 6 deletions(-) diff --git a/src/frontend/apps/desk/src/features/mail-domains/components/MailDomainsContent.tsx b/src/frontend/apps/desk/src/features/mail-domains/components/MailDomainsContent.tsx index df7ce8d..7811b7a 100644 --- a/src/frontend/apps/desk/src/features/mail-domains/components/MailDomainsContent.tsx +++ b/src/frontend/apps/desk/src/features/mail-domains/components/MailDomainsContent.tsx @@ -114,6 +114,10 @@ export function MailDomainsContent({ mailDomain }: { mailDomain: MailDomain }) { displayGoto: false, }} aria-label={t('Mailboxes list')} + hideEmptyPlaceholderImage={true} + emptyPlaceholderLabel={t( + 'No mail box was created with this mail domain.', + )} /> diff --git a/src/frontend/apps/desk/src/features/teams/member-add/components/ModalAddMembers.tsx b/src/frontend/apps/desk/src/features/teams/member-add/components/ModalAddMembers.tsx index 962e59b..17e21e2 100644 --- a/src/frontend/apps/desk/src/features/teams/member-add/components/ModalAddMembers.tsx +++ b/src/frontend/apps/desk/src/features/teams/member-add/components/ModalAddMembers.tsx @@ -158,7 +158,7 @@ export const ModalAddMembers = ({ disabled={!selectedMembers.length || isPending} onClick={() => void handleValidate()} > - {t('Validate')} + {t('Add to group')} } size={ModalSize.MEDIUM} diff --git a/src/frontend/apps/desk/src/features/teams/member-management/components/ModalDelete.tsx b/src/frontend/apps/desk/src/features/teams/member-management/components/ModalDelete.tsx index 56eb0e4..78ce41f 100644 --- a/src/frontend/apps/desk/src/features/teams/member-management/components/ModalDelete.tsx +++ b/src/frontend/apps/desk/src/features/teams/member-management/components/ModalDelete.tsx @@ -75,7 +75,7 @@ export const ModalDelete = ({ access, onClose, team }: ModalDeleteProps) => { }} disabled={isNotAllowed} > - {t('Validate')} + {t('Remove from the group')} } size={ModalSize.MEDIUM} diff --git a/src/frontend/apps/desk/src/i18n/translations.json b/src/frontend/apps/desk/src/i18n/translations.json index 14eb1e9..7e2d75b 100644 --- a/src/frontend/apps/desk/src/i18n/translations.json +++ b/src/frontend/apps/desk/src/i18n/translations.json @@ -16,6 +16,7 @@ "Add a team": "Ajouter un groupe", "Add members to the team": "Ajoutez des membres à votre groupe", "Add team icon": "Icône ajout de groupe", + "Add to group": "Ajouter au groupe", "Address: National Agency for Territorial Cohesion - 20, avenue de Ségur TSA 10717 75 334 Paris Cedex 07 Paris": "Adresse : Agence Nationale de la Cohésion des Territoires - 20, avenue de Ségur TSA 10717 75 334 Paris Cedex 07", "Administration": "Administration", "All fields are mandatory.": "Tous les champs sont obligatoires.", @@ -90,6 +91,7 @@ "My account": "Mon compte", "Names": "Noms", "New name...": "Nouveau nom...", + "No mail box was created with this mail domain.": "Aucune boîte mail n'a été créée avec ce nom de domaine.", "Nothing exceptional, no special privileges related to a .gouv.fr.": "Rien d'exceptionnel, pas de privilèges spéciaux liés à un .gouv.fr.", "Open the mail domains panel": "Ouvrir le panneau des domaines de messagerie", "Open the member options modal": "Ouvrir les options de membre dans la fenêtre modale", @@ -97,7 +99,7 @@ "Open the modal to update the role of this member": "Ouvrir la fenêtre modale pour mettre à jour le rôle de ce membre", "Open the team options": "Ouvrir les options de groupe", "Open the teams panel": "Ouvrir le panneau des groupes", - "Ouch !": "Ouch !", + "Ouch!": "Aïe !", "Owner": "Propriétaire", "Personal data and cookies": "Données personnelles et cookies", "Please enter a valid email address.\nE.g. : jean.dupont@mail.fr": "Veuillez entrer une adresse e-mail valide.\nEx. : jean.dupont@mail.fr", @@ -108,7 +110,8 @@ "Radio buttons to update the roles": "Boutons radio pour mettre à jour les rôles", "Remedy": "Voie de recours", "Remove from group": "Retirer du groupe", - "Remove this member from the group": "Retirer ce membre du groupe", + "Remove from the group": "Retirer du groupe", + "Remove this member from the group": "Retirer le membre du groupe", "Roles": "Rôles", "Régie": "Régie", "Régie Logo": "Logo Régie", diff --git a/src/frontend/apps/desk/src/pages/404.tsx b/src/frontend/apps/desk/src/pages/404.tsx index ac2e61e..d87d520 100644 --- a/src/frontend/apps/desk/src/pages/404.tsx +++ b/src/frontend/apps/desk/src/pages/404.tsx @@ -22,7 +22,7 @@ const Page: NextPageWithLayout = () => { - {t('Ouch !')} + {t('Ouch!')} diff --git a/src/frontend/apps/e2e/__tests__/app-desk/mail-domain.spec.ts b/src/frontend/apps/e2e/__tests__/app-desk/mail-domain.spec.ts index 2da30e5..439a524 100644 --- a/src/frontend/apps/e2e/__tests__/app-desk/mail-domain.spec.ts +++ b/src/frontend/apps/e2e/__tests__/app-desk/mail-domain.spec.ts @@ -119,7 +119,9 @@ test.describe('Mail domain', () => { page.getByRole('heading', { name: /domain\.fr/ }).first(), ).toBeVisible(); - await expect(page.getByText('This table is empty')).toBeVisible(); + await expect( + page.getByText('No mail box was created with this mail domain.'), + ).toBeVisible(); }); test('checks all the elements are visible when domain exists and contains 2 pages of mailboxes', async ({ diff --git a/src/frontend/apps/e2e/__tests__/app-desk/team.spec.ts b/src/frontend/apps/e2e/__tests__/app-desk/team.spec.ts index 78340dc..2ecef28 100644 --- a/src/frontend/apps/e2e/__tests__/app-desk/team.spec.ts +++ b/src/frontend/apps/e2e/__tests__/app-desk/team.spec.ts @@ -17,6 +17,7 @@ test.describe('Team', () => { ).shift(); await expect(page.getByLabel('icon group')).toBeVisible(); + await expect( page.getByRole('heading', { name: teamName,