From 8e85f303ec82a81b240232aef716f03c4a778350 Mon Sep 17 00:00:00 2001
From: Quentin BEY <quentin.bey@mail.numerique.gouv.fr>
Date: Fri, 16 May 2025 10:49:39 +0200
Subject: [PATCH] =?UTF-8?q?=F0=9F=8C=90(frontend)=20update=20some=20transl?=
 =?UTF-8?q?ated=20messages?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Slight cleanup of translations.
---
 src/frontend/apps/desk/src/components/Tag.tsx | 19 ++++++++++---------
 .../ModalDomainAccessesManagement.tsx         |  5 +++--
 .../__tests__/ModalAddMailDomain.test.tsx     |  2 +-
 .../components/MailDomainAccessesAction.tsx   |  2 +-
 .../domains/components/ModalAddMailDomain.tsx |  2 +-
 .../mailboxes/components/MailBoxesView.tsx    |  2 +-
 .../desk/src/pages/mail-domains/index.tsx     |  4 ++--
 .../e2e/__tests__/app-desk/config.spec.ts     |  2 +-
 .../app-desk/domain-provisioning.spec.ts      |  2 +-
 .../app-desk/mail-domains-add.spec.ts         | 12 +++++++++---
 .../__tests__/app-desk/mail-domains.spec.ts   |  4 ++--
 11 files changed, 32 insertions(+), 24 deletions(-)

diff --git a/src/frontend/apps/desk/src/components/Tag.tsx b/src/frontend/apps/desk/src/components/Tag.tsx
index d4c2c12..9e753f8 100644
--- a/src/frontend/apps/desk/src/components/Tag.tsx
+++ b/src/frontend/apps/desk/src/components/Tag.tsx
@@ -56,18 +56,19 @@ export const Tag = ({ ...props }: TagContentProps) => {
     Partial<Record<TagContentProps['status'], string>>
   > = {
     domain: {
-      pending: 'Domain pending validation by an administrator',
-      enabled: 'Active domain',
-      disabled: 'Disabled domain',
-      failed: 'Domain error, contact an administrator',
-      action_required:
+      pending: t('Domain pending validation by an administrator'),
+      enabled: t('Active domain'),
+      disabled: t('Disabled domain'),
+      failed: t('Domain error, contact an administrator'),
+      action_required: t(
         'A configuration action from the domain manager (outside Régie) is required',
+      ),
     },
     mail: {
-      pending: 'Email address pending validation by an administrator',
-      enabled: 'Functional email address',
-      failed: 'Email address error, contact an administrator',
-      disabled: 'Disabled email address',
+      pending: t('Email address pending validation by an administrator'),
+      enabled: t('Functional email address'),
+      failed: t('Email address error, contact an administrator'),
+      disabled: t('Disabled email address'),
     },
   };
 
diff --git a/src/frontend/apps/desk/src/features/mail-domains/access-management/components/ModalDomainAccessesManagement.tsx b/src/frontend/apps/desk/src/features/mail-domains/access-management/components/ModalDomainAccessesManagement.tsx
index 26ddf96..2a99a23 100644
--- a/src/frontend/apps/desk/src/features/mail-domains/access-management/components/ModalDomainAccessesManagement.tsx
+++ b/src/frontend/apps/desk/src/features/mail-domains/access-management/components/ModalDomainAccessesManagement.tsx
@@ -125,8 +125,9 @@ export const ModalDomainAccessesManagement = ({
       title={
         <Box $align="left" $gap="1rem">
           <Text $size="small" $margin="none">
-            {t('Droits d’administration de ')}
-            {mailDomain.name}
+            {t('Administration rights of {{name}}', {
+              name: mailDomain.name,
+            })}
           </Text>
         </Box>
       }
diff --git a/src/frontend/apps/desk/src/features/mail-domains/domains/__tests__/ModalAddMailDomain.test.tsx b/src/frontend/apps/desk/src/features/mail-domains/domains/__tests__/ModalAddMailDomain.test.tsx
index b16b2fe..6750c10 100644
--- a/src/frontend/apps/desk/src/features/mail-domains/domains/__tests__/ModalAddMailDomain.test.tsx
+++ b/src/frontend/apps/desk/src/features/mail-domains/domains/__tests__/ModalAddMailDomain.test.tsx
@@ -36,7 +36,7 @@ describe('ModalAddMailDomain', () => {
   const goToSecondStep = async () => {
     const user = userEvent.setup();
     await user.click(
-      screen.getByRole('button', { name: /I have already domain/i }),
+      screen.getByRole('button', { name: /I already have a domain/i }),
     );
   };
 
diff --git a/src/frontend/apps/desk/src/features/mail-domains/domains/components/MailDomainAccessesAction.tsx b/src/frontend/apps/desk/src/features/mail-domains/domains/components/MailDomainAccessesAction.tsx
index 8a9e9d9..a0a53a4 100644
--- a/src/frontend/apps/desk/src/features/mail-domains/domains/components/MailDomainAccessesAction.tsx
+++ b/src/frontend/apps/desk/src/features/mail-domains/domains/components/MailDomainAccessesAction.tsx
@@ -36,7 +36,7 @@ export const MailDomainAccessesAction = ({
                 setIsModalAccessOpen(true);
               }}
             >
-              {t('Share rights')}
+              {t('Access management')}
             </Button>
           )}
         </Box>
diff --git a/src/frontend/apps/desk/src/features/mail-domains/domains/components/ModalAddMailDomain.tsx b/src/frontend/apps/desk/src/features/mail-domains/domains/components/ModalAddMailDomain.tsx
index f45cead..6f536f3 100644
--- a/src/frontend/apps/desk/src/features/mail-domains/domains/components/ModalAddMailDomain.tsx
+++ b/src/frontend/apps/desk/src/features/mail-domains/domains/components/ModalAddMailDomain.tsx
@@ -114,7 +114,7 @@ export const ModalAddMailDomain = ({
       ),
       rightAction: (
         <Button data-testid="next_step" onClick={() => setStep(1)}>
-          {t('I have already domain')}
+          {t('I already have a domain')}
         </Button>
       ),
       leftAction: (
diff --git a/src/frontend/apps/desk/src/features/mail-domains/mailboxes/components/MailBoxesView.tsx b/src/frontend/apps/desk/src/features/mail-domains/mailboxes/components/MailBoxesView.tsx
index 9ab1a3d..b3004fe 100644
--- a/src/frontend/apps/desk/src/features/mail-domains/mailboxes/components/MailBoxesView.tsx
+++ b/src/frontend/apps/desk/src/features/mail-domains/mailboxes/components/MailBoxesView.tsx
@@ -122,7 +122,7 @@ export function MailBoxesView({ mailDomain }: { mailDomain: MailDomain }) {
                 {t('New mail address')}
               </Button>
             ) : (
-              <Tooltip content="You don't have the correct access right">
+              <Tooltip content={t("You don't have the correct access right")}>
                 <div>
                   <Button
                     data-testid="button-new-mailbox"
diff --git a/src/frontend/apps/desk/src/pages/mail-domains/index.tsx b/src/frontend/apps/desk/src/pages/mail-domains/index.tsx
index e2304ba..3d9c6ac 100644
--- a/src/frontend/apps/desk/src/pages/mail-domains/index.tsx
+++ b/src/frontend/apps/desk/src/pages/mail-domains/index.tsx
@@ -55,7 +55,7 @@ const Page: NextPageWithLayout = () => {
           as="h2"
           $css="font-weight: 700; font-size: 1.5rem; margin-bottom: 20px;"
         >
-          {t('Areas of the organization')}
+          {t('Domains of the organization')}
         </Text>
 
         <Box
@@ -111,7 +111,7 @@ const Page: NextPageWithLayout = () => {
                 {t('Add a mail domain')}
               </Button>
             ) : (
-              <Tooltip content="You don't have the correct access right">
+              <Tooltip content={t("You don't have the correct access right")}>
                 <div>
                   <Button
                     data-testid="button-new-domain"
diff --git a/src/frontend/apps/e2e/__tests__/app-desk/config.spec.ts b/src/frontend/apps/e2e/__tests__/app-desk/config.spec.ts
index 84d08c5..6cb305b 100644
--- a/src/frontend/apps/e2e/__tests__/app-desk/config.spec.ts
+++ b/src/frontend/apps/e2e/__tests__/app-desk/config.spec.ts
@@ -47,7 +47,7 @@ test.describe('Config', () => {
 
     await expect(page).toHaveURL(/mail-domains\//);
 
-    await expect(page.getByText('Areas of the organization')).toBeVisible();
+    await expect(page.getByText('Domains of the organization')).toBeVisible();
   });
 
   // test('it checks that the user abilities display teams', async ({
diff --git a/src/frontend/apps/e2e/__tests__/app-desk/domain-provisioning.spec.ts b/src/frontend/apps/e2e/__tests__/app-desk/domain-provisioning.spec.ts
index c0c1059..8b8dfee 100644
--- a/src/frontend/apps/e2e/__tests__/app-desk/domain-provisioning.spec.ts
+++ b/src/frontend/apps/e2e/__tests__/app-desk/domain-provisioning.spec.ts
@@ -17,7 +17,7 @@ test.describe('When a commune, domain is created on first login via ProConnect',
     await page.waitForURL('http://localhost:3000/mail-domains/**');
     await expect(
       page.getByRole('heading', {
-        name: 'Areas of the organization',
+        name: 'Domains of the organization',
         exact: true,
       }),
     ).toBeVisible();
diff --git a/src/frontend/apps/e2e/__tests__/app-desk/mail-domains-add.spec.ts b/src/frontend/apps/e2e/__tests__/app-desk/mail-domains-add.spec.ts
index 9f0f493..97cb12a 100644
--- a/src/frontend/apps/e2e/__tests__/app-desk/mail-domains-add.spec.ts
+++ b/src/frontend/apps/e2e/__tests__/app-desk/mail-domains-add.spec.ts
@@ -38,7 +38,9 @@ test.describe('Add Mail Domains', () => {
 
     await expect(buttonClose).toBeVisible();
 
-    await page.getByRole('button', { name: /I have already domain/i }).click();
+    await page
+      .getByRole('button', { name: /I already have a domain/i })
+      .click();
 
     await expect(modal).toBeVisible();
     await expect(inputName).toBeVisible();
@@ -60,7 +62,9 @@ test.describe('Add Mail Domains', () => {
     await page.goto('/mail-domains/');
     await page.getByTestId('button-new-domain').click();
 
-    await page.getByRole('button', { name: /I have already domain/i }).click();
+    await page
+      .getByRole('button', { name: /I already have a domain/i })
+      .click();
     const { inputName, buttonSubmit } = getElements(page);
 
     await expect(buttonSubmit).toBeDisabled();
@@ -79,7 +83,9 @@ test.describe('Add Mail Domains', () => {
     await page.goto('/mail-domains/');
     await page.getByTestId('button-new-domain').click();
 
-    await page.getByRole('button', { name: /I have already domain/i }).click();
+    await page
+      .getByRole('button', { name: /I already have a domain/i })
+      .click();
 
     const { inputName, inputSupportEmail, buttonSubmit, modal } =
       getElements(page);
diff --git a/src/frontend/apps/e2e/__tests__/app-desk/mail-domains.spec.ts b/src/frontend/apps/e2e/__tests__/app-desk/mail-domains.spec.ts
index 12d49c0..4493a06 100644
--- a/src/frontend/apps/e2e/__tests__/app-desk/mail-domains.spec.ts
+++ b/src/frontend/apps/e2e/__tests__/app-desk/mail-domains.spec.ts
@@ -98,7 +98,7 @@ test.describe('Mail domains', () => {
         .getByLabel(`Mail Domains button`)
         .click();
       await expect(page).toHaveURL(/mail-domains\//);
-      await expect(page.getByText('Areas of the organization')).toBeVisible();
+      await expect(page.getByText('Domains of the organization')).toBeVisible();
       await expect(page.getByText('No domains exist.')).toBeVisible();
     });
 
@@ -127,7 +127,7 @@ test.describe('Mail domains', () => {
         .getByLabel(`Mail Domains button`)
         .click();
       await expect(page).toHaveURL(/mail-domains\//);
-      await expect(page.getByText('Areas of the organization')).toBeVisible();
+      await expect(page.getByText('Domains of the organization')).toBeVisible();
       await expect(page.getByText('Manage')).toHaveCount(4);
 
       await Promise.all(