From 97d9714a0d421d9c44ca3a3a14dfd9c961dee86b Mon Sep 17 00:00:00 2001
From: Anthony LC <anthony.le-courric@mail.numerique.gouv.fr>
Date: Wed, 13 Mar 2024 16:05:55 +0100
Subject: [PATCH] =?UTF-8?q?=F0=9F=90=9B(app-desk)=20close=20dropDown=20whe?=
 =?UTF-8?q?n=20click=20outside?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

When we were clicking outside the dropdown,
the dropdown was not closing.
This commit fixes that.
---
 .../apps/desk/src/components/DropButton.tsx   | 25 +++++++++++--------
 1 file changed, 14 insertions(+), 11 deletions(-)

diff --git a/src/frontend/apps/desk/src/components/DropButton.tsx b/src/frontend/apps/desk/src/components/DropButton.tsx
index ab1ba90..2493c9c 100644
--- a/src/frontend/apps/desk/src/components/DropButton.tsx
+++ b/src/frontend/apps/desk/src/components/DropButton.tsx
@@ -44,19 +44,22 @@ export const DropButton = ({
     setIsLocalOpen(isOpen);
   }, [isOpen]);
 
+  const onOpenChangeHandler = (isOpen: boolean) => {
+    setIsLocalOpen(isOpen);
+    onOpenChange?.(isOpen);
+    setTimeout(() => {
+      setOpacity(isOpen);
+    }, 10);
+  };
+
   return (
-    <DialogTrigger
-      onOpenChange={(isOpen) => {
-        setIsLocalOpen(isOpen);
-        onOpenChange?.(isOpen);
-        setTimeout(() => {
-          setOpacity(isOpen);
-        }, 10);
-      }}
-      isOpen={isLocalOpen}
-    >
+    <DialogTrigger onOpenChange={onOpenChangeHandler} isOpen={isLocalOpen}>
       <StyledButton>{button}</StyledButton>
-      <StyledPopover style={{ opacity: opacity ? 1 : 0 }} isOpen={isLocalOpen}>
+      <StyledPopover
+        style={{ opacity: opacity ? 1 : 0 }}
+        isOpen={isLocalOpen}
+        onOpenChange={onOpenChangeHandler}
+      >
         {children}
       </StyledPopover>
     </DialogTrigger>