✅(dimail) fix tests still waiting for domain.secret

For unknown reasons, these tests were forgotten and are still
refering to this 'secret' field, removed in last commit.

src/backend/mailbox_manager/tests/api/mailboxes/test_api_mailboxes_create.py

@@ -5,6 +5,8 @@ Unit tests for the mailbox API
 import json
 import re
 
+from django.test.utils import override_settings
+
 import pytest
 import responses
 from rest_framework import status
@@ -361,14 +363,14 @@ def test_api_mailboxes__domain_owner_or_admin_successful_creation_and_provisioni
     assert mailbox.secondary_email == mailbox_data["secondary_email"]
 
 
-def test_api_mailboxes__wrong_secret_no_token_error():
+@override_settings(MAIL_PROVISIONING_API_CREDENTIALS="wrongCredentials")
+def test_api_mailboxes__dimail_token_permission_denied():
     """
     API should raise a clear "permission denied" error
     when receiving a 403_forbidden from dimail.
     """
     # creating all needed objects
     access = factories.MailDomainAccessFactory(role=enums.MailDomainRoleChoices.OWNER)
-    access.domain.secret = "nottherealsecret"
 
     client = APIClient()
     client.force_login(access.user)
@@ -394,15 +396,16 @@ def test_api_mailboxes__wrong_secret_no_token_error():
 
         assert response.status_code == status.HTTP_403_FORBIDDEN
         assert response.json() == {
-            "detail": f"Token denied - Wrong secret on mail domain {access.domain.name}"
+            "detail": "Token denied. Please check your MAIL_PROVISIONING_API_CREDENTIALS."
         }
         assert not models.Mailbox.objects.exists()
 
 
-def test_api_mailboxes__secret_unrelated_to_domain():
+def test_api_mailboxes__user_unrelated_to_domain():
     """
-    API should raise a clear "permission denied"
+    API should raise a clear "permission denied" when dimail returns a permission denied
-    when secret allows for a token but is not linked to queried domain on dimail-api.
+    on mailbox creation. This means token was granted for this user
+    but user is not allowed to modify this domain (i.e. not owner)
     """
     # creating all needed objects
     access = factories.MailDomainAccessFactory(role=enums.MailDomainRoleChoices.OWNER)

src/backend/mailbox_manager/tests/test_models_mailboxes.py

@@ -145,7 +145,7 @@ def test_models_mailboxes__cannot_be_created_for_pending_maildomain():
 
 
 @override_settings(MAIL_PROVISIONING_API_CREDENTIALS=None)
-def test_models_mailboxes__no_secret():
+def test_models_mailboxes__dimail_no_credentials():
     """
     If MAIL_PROVISIONING_API_CREDENTIALS setting is not configured,
     trying to create a mailbox should raise an error.
@@ -159,8 +159,12 @@ def test_models_mailboxes__no_secret():
         factories.MailboxFactory(domain=domain)
 
 
-def test_models_mailboxes__wrong_secret():
+@override_settings(MAIL_PROVISIONING_API_CREDENTIALS="wrongCredentials")
-    """If domain secret is inaccurate, the function should raise an error."""
+def test_models_mailboxes__dimail_token_permissions_denied():
+    """
+    Our API should raise a clear "Permission denied" error
+    if dimail returns a permission denied on /token/ endpoint.
+    """
 
     domain = factories.MailDomainEnabledFactory()
 
@@ -176,7 +180,7 @@ def test_models_mailboxes__wrong_secret():
 
         with pytest.raises(
             exceptions.PermissionDenied,
-            match=f"Token denied - Wrong secret on mail domain {domain.name}",
+            match="Token denied. Please check your MAIL_PROVISIONING_API_CREDENTIALS.",
         ):
             mailbox = factories.MailboxFactory(use_mock=False, domain=domain)
             # Payload sent to mailbox provider