From bd6cd59df6decb53c0dddf29894c18167e7079ad Mon Sep 17 00:00:00 2001
From: daproclaima <sebastien@devedanos.com>
Date: Fri, 6 Sep 2024 22:56:36 +0200
Subject: [PATCH] =?UTF-8?q?=F0=9F=92=AC(frontend)=20change=20add=20mail=20?=
 =?UTF-8?q?domain=20text?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

- update translations and tests
---
 CHANGELOG.md                                         |  1 +
 .../mail-domains/components/ModalAddMailDomain.tsx   |  2 +-
 .../mail-domains/components/panel/PanelActions.tsx   |  2 +-
 src/frontend/apps/desk/src/i18n/translations.json    |  6 +-----
 .../apps/desk/src/pages/mail-domains/index.tsx       |  2 +-
 .../apps/e2e/__tests__/app-desk/config.spec.ts       |  2 +-
 .../e2e/__tests__/app-desk/mail-domains-add.spec.ts  | 12 ++++++------
 7 files changed, 12 insertions(+), 15 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 875d86a..cb97d60 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -16,6 +16,7 @@ and this project adheres to
 
 - 🐛(dimail) improve handling of dimail errors on failed mailbox creation #377
 -  💬(frontend) fix group member removal text #382
+-  💬(frontend) fix add mail domain text #382
 
 ## [1.0.2] - 2024-08-30
 
diff --git a/src/frontend/apps/desk/src/features/mail-domains/components/ModalAddMailDomain.tsx b/src/frontend/apps/desk/src/features/mail-domains/components/ModalAddMailDomain.tsx
index c3fef7c..aed9f41 100644
--- a/src/frontend/apps/desk/src/features/mail-domains/components/ModalAddMailDomain.tsx
+++ b/src/frontend/apps/desk/src/features/mail-domains/components/ModalAddMailDomain.tsx
@@ -100,7 +100,7 @@ export const ModalCreateMailDomain = () => {
         <>
           <MailDomainsLogo aria-hidden="true" />
           <Text as="h3" $textAlign="center">
-            {t('Add your mail domain')}
+            {t('Add a mail domain')}
           </Text>
         </>
       }
diff --git a/src/frontend/apps/desk/src/features/mail-domains/components/panel/PanelActions.tsx b/src/frontend/apps/desk/src/features/mail-domains/components/panel/PanelActions.tsx
index 990afc8..d04b632 100644
--- a/src/frontend/apps/desk/src/features/mail-domains/components/panel/PanelActions.tsx
+++ b/src/frontend/apps/desk/src/features/mail-domains/components/panel/PanelActions.tsx
@@ -46,7 +46,7 @@ export const PanelActions = () => {
       <StyledLink href="/mail-domains/add/">
         <Text
           $margin="auto"
-          aria-label={t('Add your mail domain')}
+          aria-label={t('Add a mail domain')}
           $theme="primary"
         >
           <IconAdd width={27} height={27} aria-hidden="true" />
diff --git a/src/frontend/apps/desk/src/i18n/translations.json b/src/frontend/apps/desk/src/i18n/translations.json
index af09ea7..403680d 100644
--- a/src/frontend/apps/desk/src/i18n/translations.json
+++ b/src/frontend/apps/desk/src/i18n/translations.json
@@ -11,12 +11,12 @@
       "0 group to display.": "0 groupe à afficher.",
       "Accessibility statement": "Déclaration d'accessibilité",
       "Accessibility: non-compliant": "Accessibilité : non conforme",
+      "Add a mail domain": "Ajouter un nom de domaine",
       "Add a member": "Ajouter un membre",
       "Add a team": "Ajouter un groupe",
       "Add members to the team": "Ajouter des membres à l'équipe",
       "Add the domain": "Ajouter le domaine",
       "Add to group": "Ajouter au groupe",
-      "Add your mail domain": "Ajouter votre nom de domaine",
       "Address: National Agency for Territorial Cohesion - 20, avenue de Ségur TSA 10717 75 334 Paris Cedex 07 Paris": "Adresse : Agence Nationale de la Cohésion des Territoires - 20, avenue de Ségur TSA 10717 75 334 Paris Cedex 07",
       "Administration": "Administration",
       "All fields are mandatory.": "Tous les champs sont obligatoires.",
@@ -83,10 +83,8 @@
       "List members card": "Carte liste des membres",
       "Logout": "Se déconnecter",
       "Mail Domains": "Domaines de messagerie",
-      "Mail domain addition form": "Formulaire d'ajout de domaine de messagerie",
       "Mail domains panel": "Panel des domaines de messagerie",
       "Mailbox created!": "Boîte mail créée !",
-      "Mailbox creation form": "Formulaire de création de boite mail",
       "Mailboxes list": "Liste des boîtes mail",
       "Marianne Logo": "Logo Marianne",
       "Member": "Membre",
@@ -136,7 +134,6 @@
       "Teams": "Équipes",
       "The National Agency for Territorial Cohesion undertakes to make its\n          service accessible, in accordance with article 47 of law no. 2005-102\n          of February 11, 2005.": "L'Agence Nationale de la Cohésion des Territoires s’engage à rendre son service accessible, conformément à l’article 47 de la loi n° 2005-102 du 11 février 2005.",
       "The domain name encounters an error. Please contact our support team to solve the problem:": "Le nom de domaine rencontre une erreur. Veuillez contacter notre support pour résoudre le problème :",
-      "The mail domain secret is misconfigured. Please, contact our support team to solve the issue: suiteterritoriale@anct.gouv.fr": "Le secret du domaine de messagerie est mal configuré. Veuillez contacter notre support pour résoudre le problème : suiteterritoriale@anct.gouv.fr",
       "The member has been removed from the team": "Le membre a été supprimé de votre groupe",
       "The role has been updated": "Le rôle a bien été mis à jour",
       "The team has been removed.": "Le groupe a été supprimé.",
@@ -167,7 +164,6 @@
       "You cannot update the role of other owner.": "Vous ne pouvez pas mettre à jour les rôles d'autre propriétaire.",
       "You must have minimum 1 character": "Vous devez entrer au moins 1 caractère",
       "Your domain name is being validated.  You will not be able to create mailboxes until your domain name has been validated by our team.": "Votre nom de domaine est en cours de validation. Vous ne pourrez créer de boîtes mail que lorsque votre nom de domaine sera validé par notre équipe.",
-      "Your request cannot be processed because the server is experiencing an error. If the problem persists, please contact our support to resolve the issue: suiteterritoriale@anct.gouv.fr": "Votre demande ne peut pas être traitée car le serveur rencontre une erreur. Si le problème persiste, veuillez contacter notre support pour résoudre le problème : suiteterritoriale@anct.gouv.fr",
       "[disabled]": "[désactivé]",
       "[enabled]": "[actif]",
       "[failed]": "[erroné]",
diff --git a/src/frontend/apps/desk/src/pages/mail-domains/index.tsx b/src/frontend/apps/desk/src/pages/mail-domains/index.tsx
index 622c0d7..15c53c4 100644
--- a/src/frontend/apps/desk/src/pages/mail-domains/index.tsx
+++ b/src/frontend/apps/desk/src/pages/mail-domains/index.tsx
@@ -20,7 +20,7 @@ const Page: NextPageWithLayout = () => {
   return (
     <Box $align="center" $justify="center" $height="inherit">
       <StyledButton onClick={() => void router.push('/mail-domains/add')}>
-        {t('Add your mail domain')}
+        {t('Add a mail domain')}
       </StyledButton>
     </Box>
   );
diff --git a/src/frontend/apps/e2e/__tests__/app-desk/config.spec.ts b/src/frontend/apps/e2e/__tests__/app-desk/config.spec.ts
index b6d2937..0dc0391 100644
--- a/src/frontend/apps/e2e/__tests__/app-desk/config.spec.ts
+++ b/src/frontend/apps/e2e/__tests__/app-desk/config.spec.ts
@@ -56,7 +56,7 @@ test.describe('Config', () => {
 
     await expect(
       page.getByRole('button', {
-        name: 'Add your mail domain',
+        name: 'Add a mail domain',
       }),
     ).toBeVisible();
   });
diff --git a/src/frontend/apps/e2e/__tests__/app-desk/mail-domains-add.spec.ts b/src/frontend/apps/e2e/__tests__/app-desk/mail-domains-add.spec.ts
index 82dc60b..4807825 100644
--- a/src/frontend/apps/e2e/__tests__/app-desk/mail-domains-add.spec.ts
+++ b/src/frontend/apps/e2e/__tests__/app-desk/mail-domains-add.spec.ts
@@ -12,7 +12,7 @@ test.describe('Add Mail Domains', () => {
     await page.goto('/mail-domains');
 
     const buttonFromHomePage = page.getByRole('button', {
-      name: 'Add your mail domain',
+      name: 'Add a mail domain',
     });
 
     await expect(buttonFromHomePage).toBeVisible();
@@ -22,7 +22,7 @@ test.describe('Add Mail Domains', () => {
 
     await expect(
       page.getByRole('heading', {
-        name: 'Add your mail domain',
+        name: 'Add a mail domain',
         level: 3,
       }),
     ).toBeVisible();
@@ -49,7 +49,7 @@ test.describe('Add Mail Domains', () => {
     await page.goto('/mail-domains');
 
     const buttonFromHomePage = page.getByRole('button', {
-      name: 'Add your mail domain',
+      name: 'Add a mail domain',
     });
     await buttonFromHomePage.click();
 
@@ -68,7 +68,7 @@ test.describe('Add Mail Domains', () => {
     await page.goto('/mail-domains');
 
     const buttonFromHomePage = page.getByRole('button', {
-      name: 'Add your mail domain',
+      name: 'Add a mail domain',
     });
     await buttonFromHomePage.click();
 
@@ -109,7 +109,7 @@ test.describe('Add Mail Domains', () => {
 
     const panel = page.getByLabel('Mail domains panel').first();
 
-    await panel.getByRole('link', { name: 'Add your mail domain' }).click();
+    await panel.getByRole('link', { name: 'Add a mail domain' }).click();
 
     const form = page.locator('form');
 
@@ -133,7 +133,7 @@ test.describe('Add Mail Domains', () => {
 
     const panel = page.getByLabel('Mail domains panel').first();
     const additionLink = panel.getByRole('link', {
-      name: 'Add your mail domain',
+      name: 'Add a mail domain',
     });
     const form = page.locator('form');
     const inputName = form.getByLabel('Domain name');