From bf1450cfa78d079b0984e38dc212842e650b1469 Mon Sep 17 00:00:00 2001
From: Anthony LC <anthony.le-courric@mail.numerique.gouv.fr>
Date: Fri, 29 Mar 2024 14:26:59 +0100
Subject: [PATCH] =?UTF-8?q?=E2=9A=A1=EF=B8=8F(app-desk)=20remove=20firefox?=
 =?UTF-8?q?=20from=20e2e=20tests?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

- Remove Firefox testing, Firefox browser seems unstable with
Playwright, most of the time the failing tests are the one
with Firefox, Firefox is only 3% of the browser.
- Improve some naming in the test creation to avoid
conflit name.
---
 .../apps/e2e/__tests__/app-desk/member-delete.spec.ts  | 10 +++++-----
 .../apps/e2e/__tests__/app-desk/teams-delete.spec.ts   |  6 +++---
 src/frontend/apps/e2e/playwright.config.ts             |  6 ------
 3 files changed, 8 insertions(+), 14 deletions(-)

diff --git a/src/frontend/apps/e2e/__tests__/app-desk/member-delete.spec.ts b/src/frontend/apps/e2e/__tests__/app-desk/member-delete.spec.ts
index b1ffb11..e43d3be 100644
--- a/src/frontend/apps/e2e/__tests__/app-desk/member-delete.spec.ts
+++ b/src/frontend/apps/e2e/__tests__/app-desk/member-delete.spec.ts
@@ -35,7 +35,7 @@ test.describe('Members Delete', () => {
     page,
     browserName,
   }) => {
-    await createTeam(page, 'member-delete-1', browserName, 1);
+    await createTeam(page, 'member-delete-2', browserName, 1);
 
     await addNewMember(page, 0, 'Owner');
 
@@ -59,7 +59,7 @@ test.describe('Members Delete', () => {
   });
 
   test('it cannot delete owner member', async ({ page, browserName }) => {
-    await createTeam(page, 'member-delete-1', browserName, 1);
+    await createTeam(page, 'member-delete-3', browserName, 1);
 
     const username = await addNewMember(page, 0, 'Owner');
 
@@ -80,7 +80,7 @@ test.describe('Members Delete', () => {
   });
 
   test('it deletes admin member', async ({ page, browserName }) => {
-    await createTeam(page, 'member-delete-1', browserName, 1);
+    await createTeam(page, 'member-delete-4', browserName, 1);
 
     const username = await addNewMember(page, 0, 'Admin');
 
@@ -105,7 +105,7 @@ test.describe('Members Delete', () => {
     page,
     browserName,
   }) => {
-    await createTeam(page, 'member-delete-1', browserName, 1);
+    await createTeam(page, 'member-delete-5', browserName, 1);
 
     const username = await addNewMember(page, 0, 'Owner');
 
@@ -132,7 +132,7 @@ test.describe('Members Delete', () => {
   });
 
   test('it deletes admin member when admin', async ({ page, browserName }) => {
-    await createTeam(page, 'member-delete-1', browserName, 1);
+    await createTeam(page, 'member-delete-6', browserName, 1);
 
     // To not be the only owner
     await addNewMember(page, 0, 'Owner');
diff --git a/src/frontend/apps/e2e/__tests__/app-desk/teams-delete.spec.ts b/src/frontend/apps/e2e/__tests__/app-desk/teams-delete.spec.ts
index 65fbe34..159a7ef 100644
--- a/src/frontend/apps/e2e/__tests__/app-desk/teams-delete.spec.ts
+++ b/src/frontend/apps/e2e/__tests__/app-desk/teams-delete.spec.ts
@@ -12,7 +12,7 @@ test.describe('Teams Delete', () => {
     page,
     browserName,
   }) => {
-    await createTeam(page, 'team-update-name', browserName, 1);
+    await createTeam(page, 'team-update-name-1', browserName, 1);
 
     await page.getByLabel(`Open the team options`).click();
     await page.getByRole('button', { name: `Delete the team` }).click();
@@ -27,7 +27,7 @@ test.describe('Teams Delete', () => {
     page,
     browserName,
   }) => {
-    await createTeam(page, 'team-update-name', browserName, 1);
+    await createTeam(page, 'team-update-name-2', browserName, 1);
 
     await addNewMember(page, 0, 'Owner');
 
@@ -55,7 +55,7 @@ test.describe('Teams Delete', () => {
     page,
     browserName,
   }) => {
-    await createTeam(page, 'team-update-name', browserName, 1);
+    await createTeam(page, 'team-update-name-3', browserName, 1);
 
     await addNewMember(page, 0, 'Owner');
 
diff --git a/src/frontend/apps/e2e/playwright.config.ts b/src/frontend/apps/e2e/playwright.config.ts
index 8179436..482c3c4 100644
--- a/src/frontend/apps/e2e/playwright.config.ts
+++ b/src/frontend/apps/e2e/playwright.config.ts
@@ -46,12 +46,6 @@ export default defineConfig({
       name: 'chromium',
       use: { ...devices['Desktop Chrome'], locale: 'en-US' },
     },
-
-    {
-      name: 'firefox',
-      use: { ...devices['Desktop Firefox'], locale: 'en-US' },
-    },
-
     {
       name: 'webkit',
       use: { ...devices['Desktop Safari'], locale: 'en-US' },