diff --git a/src/backend/core/tests/teams/test_core_api_teams_create.py b/src/backend/core/tests/teams/test_core_api_teams_create.py index 21289fa..af6c1c0 100644 --- a/src/backend/core/tests/teams/test_core_api_teams_create.py +++ b/src/backend/core/tests/teams/test_core_api_teams_create.py @@ -2,6 +2,11 @@ Tests for Teams API endpoint in People's core app: create """ import pytest +from rest_framework.status import ( + HTTP_201_CREATED, + HTTP_400_BAD_REQUEST, + HTTP_401_UNAUTHORIZED, +) from rest_framework.test import APIClient from core.factories import IdentityFactory, TeamFactory @@ -20,7 +25,7 @@ def test_api_teams_create_anonymous(): }, ) - assert response.status_code == 401 + assert response.status_code == HTTP_401_UNAUTHORIZED assert not Team.objects.exists() @@ -42,7 +47,7 @@ def test_api_teams_create_authenticated(): HTTP_AUTHORIZATION=f"Bearer {jwt_token}", ) - assert response.status_code == 201 + assert response.status_code == HTTP_201_CREATED team = Team.objects.get() assert team.name == "my team" assert team.accesses.filter(role="owner", user=user).exists() @@ -61,7 +66,7 @@ def test_api_teams_create_authenticated_slugify_name(): HTTP_AUTHORIZATION=f"Bearer {jwt_token}", ) - assert response.status_code == 201 + assert response.status_code == HTTP_201_CREATED team = Team.objects.get() assert team.name == "my team" assert team.slug == "my-team" @@ -92,7 +97,7 @@ def test_api_teams_create_authenticated_expected_slug(param): HTTP_AUTHORIZATION=f"Bearer {jwt_token}", ) - assert response.status_code == 201 + assert response.status_code == HTTP_201_CREATED team = Team.objects.get() assert team.name == param[0] assert team.slug == param[1] @@ -114,5 +119,5 @@ def test_api_teams_create_authenticated_unique_slugs(): HTTP_AUTHORIZATION=f"Bearer {jwt_token}", ) - assert response.status_code == 400 + assert response.status_code == HTTP_400_BAD_REQUEST assert response.json()["slug"] == ["Team with this Slug already exists."] diff --git a/src/backend/core/tests/teams/test_core_api_teams_delete.py b/src/backend/core/tests/teams/test_core_api_teams_delete.py index 816e443..6c34970 100644 --- a/src/backend/core/tests/teams/test_core_api_teams_delete.py +++ b/src/backend/core/tests/teams/test_core_api_teams_delete.py @@ -2,12 +2,16 @@ Tests for Teams API endpoint in People's core app: delete """ import pytest +from rest_framework.status import ( + HTTP_204_NO_CONTENT, + HTTP_401_UNAUTHORIZED, + HTTP_403_FORBIDDEN, + HTTP_404_NOT_FOUND, +) from rest_framework.test import APIClient -from rest_framework_simplejwt.tokens import AccessToken from core import factories, models - -from ..utils import OIDCToken +from core.tests.utils import OIDCToken pytestmark = pytest.mark.django_db @@ -20,7 +24,7 @@ def test_api_teams_delete_anonymous(): f"/api/v1.0/teams/{team.id!s}/", ) - assert response.status_code == 401 + assert response.status_code == HTTP_401_UNAUTHORIZED assert models.Team.objects.count() == 1 @@ -39,7 +43,7 @@ def test_api_teams_delete_authenticated_unrelated(): f"/api/v1.0/teams/{team.id!s}/", HTTP_AUTHORIZATION=f"Bearer {jwt_token}" ) - assert response.status_code == 404 + assert response.status_code == HTTP_404_NOT_FOUND assert response.json() == {"detail": "Not found."} assert models.Team.objects.count() == 1 @@ -59,7 +63,7 @@ def test_api_teams_delete_authenticated_member(): f"/api/v1.0/teams/{team.id}/", HTTP_AUTHORIZATION=f"Bearer {jwt_token}" ) - assert response.status_code == 403 + assert response.status_code == HTTP_403_FORBIDDEN assert response.json() == { "detail": "You do not have permission to perform this action." } @@ -81,7 +85,7 @@ def test_api_teams_delete_authenticated_administrator(): f"/api/v1.0/teams/{team.id}/", HTTP_AUTHORIZATION=f"Bearer {jwt_token}" ) - assert response.status_code == 403 + assert response.status_code == HTTP_403_FORBIDDEN assert response.json() == { "detail": "You do not have permission to perform this action." } @@ -103,5 +107,5 @@ def test_api_teams_delete_authenticated_owner(): f"/api/v1.0/teams/{team.id}/", HTTP_AUTHORIZATION=f"Bearer {jwt_token}" ) - assert response.status_code == 204 + assert response.status_code == HTTP_204_NO_CONTENT assert models.Team.objects.exists() is False diff --git a/src/backend/core/tests/teams/test_core_api_teams_retrieve.py b/src/backend/core/tests/teams/test_core_api_teams_retrieve.py index df3ae7a..4fdd8d9 100644 --- a/src/backend/core/tests/teams/test_core_api_teams_retrieve.py +++ b/src/backend/core/tests/teams/test_core_api_teams_retrieve.py @@ -2,6 +2,7 @@ Tests for Teams API endpoint in People's core app: retrieve """ import pytest +from rest_framework.status import HTTP_200_OK, HTTP_401_UNAUTHORIZED, HTTP_404_NOT_FOUND from rest_framework.test import APIClient from core import factories @@ -15,7 +16,7 @@ def test_api_teams_retrieve_anonymous(): team = factories.TeamFactory() response = APIClient().get(f"/api/v1.0/teams/{team.id}/") - assert response.status_code == 401 + assert response.status_code == HTTP_401_UNAUTHORIZED assert response.json() == { "detail": "Authentication credentials were not provided." } @@ -35,7 +36,7 @@ def test_api_teams_retrieve_authenticated_unrelated(): response = APIClient().get( f"/api/v1.0/teams/{team.id!s}/", HTTP_AUTHORIZATION=f"Bearer {jwt_token}" ) - assert response.status_code == 404 + assert response.status_code == HTTP_404_NOT_FOUND assert response.json() == {"detail": "Not found."} @@ -55,7 +56,7 @@ def test_api_teams_retrieve_authenticated_related(): response = APIClient().get( f"/api/v1.0/teams/{team.id!s}/", HTTP_AUTHORIZATION=f"Bearer {jwt_token}" ) - assert response.status_code == 200 + assert response.status_code == HTTP_200_OK content = response.json() assert sorted(content.pop("accesses"), key=lambda x: x["user"]) == sorted( [ diff --git a/src/backend/core/tests/teams/test_core_api_teams_update.py b/src/backend/core/tests/teams/test_core_api_teams_update.py index 7500b64..e9404ff 100644 --- a/src/backend/core/tests/teams/test_core_api_teams_update.py +++ b/src/backend/core/tests/teams/test_core_api_teams_update.py @@ -4,6 +4,13 @@ Tests for Teams API endpoint in People's core app: update import random import pytest +from rest_framework.status import ( + HTTP_200_OK, + HTTP_400_BAD_REQUEST, + HTTP_401_UNAUTHORIZED, + HTTP_403_FORBIDDEN, + HTTP_404_NOT_FOUND, +) from rest_framework.test import APIClient from core import factories @@ -24,7 +31,7 @@ def test_api_teams_update_anonymous(): new_team_values, format="json", ) - assert response.status_code == 401 + assert response.status_code == HTTP_401_UNAUTHORIZED assert response.json() == { "detail": "Authentication credentials were not provided." } @@ -53,7 +60,7 @@ def test_api_teams_update_authenticated_unrelated(): HTTP_AUTHORIZATION=f"Bearer {jwt_token}", ) - assert response.status_code == 404 + assert response.status_code == HTTP_404_NOT_FOUND assert response.json() == {"detail": "Not found."} team.refresh_from_db() @@ -81,7 +88,7 @@ def test_api_teams_update_authenticated_members(): HTTP_AUTHORIZATION=f"Bearer {jwt_token}", ) - assert response.status_code == 403 + assert response.status_code == HTTP_403_FORBIDDEN assert response.json() == { "detail": "You do not have permission to perform this action." } @@ -108,7 +115,7 @@ def test_api_teams_update_authenticated_administrators(): format="json", HTTP_AUTHORIZATION=f"Bearer {jwt_token}", ) - assert response.status_code == 200 + assert response.status_code == HTTP_200_OK team.refresh_from_db() final_values = serializers.TeamSerializer(instance=team).data @@ -139,7 +146,7 @@ def test_api_teams_update_authenticated_owners(): format="json", HTTP_AUTHORIZATION=f"Bearer {jwt_token}", ) - assert response.status_code == 200 + assert response.status_code == HTTP_200_OK team.refresh_from_db() team_values = serializers.TeamSerializer(instance=team).data @@ -172,7 +179,7 @@ def test_api_teams_update_administrator_or_owner_of_another(): HTTP_AUTHORIZATION=f"Bearer {jwt_token}", ) - assert response.status_code == 404 + assert response.status_code == HTTP_404_NOT_FOUND assert response.json() == {"detail": "Not found."} team.refresh_from_db() @@ -201,7 +208,7 @@ def test_api_teams_update_existing_slug_should_return_error(): format="json", HTTP_AUTHORIZATION=f"Bearer {jwt_token}", ) - assert response.status_code == 400 + assert response.status_code == HTTP_400_BAD_REQUEST assert response.json()["slug"] == ["Team with this Slug already exists."] # Both teams names and slugs should be unchanged assert my_team.name == "New team"