studio/people
Archived
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

🔥(frontend) remove use of phone number data for mailbox creation

Browse Source 
Remove phone number field from mailbox creation form and requests
to comply with GPDR as it is not an information we need to
collect for creating a mailbox. Deletes translations about phone
number field in mailbox creation form. Updates related e2e tests.
This commit is contained in:
daproclaima
2024-07-03 14:16:15 +02:00
committed by Sebastien Nobour
parent 66300aca66
commit d69861c148
4 changed files with 8 additions and 39 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
src/frontend/apps/e2e/__tests__/app-desk/mail-domain-create-mailbox.spec.ts
View File

@@ -144,8 +144,7 @@ test.describe('Mail domain create mailbox', () => {
payload.first_name === 'John' &&
payload.last_name === 'Doe' &&
payload.local_part === 'john.doe' &&
payload.secondary_email === 'john.doe@mail.com' &&
payload.phone_number === '003371020304050';
payload.secondary_email === 'john.doe@mail.com';
}
}
});
@@ -173,7 +172,6 @@ test.describe('Mail domain create mailbox', () => {
await page.getByLabel('Main email address').fill('john.doe');
await expect(page.locator('span').getByText('@domain.fr')).toBeVisible();
await page.getByLabel('Secondary email address').fill('john.doe@mail.com');
await page.getByLabel('Phone number').fill('003371020304050');
await page.getByRole('button', { name: 'Submit' }).click();
@@ -240,14 +238,13 @@ test.describe('Mail domain create mailbox', () => {
};
let isCreateMailboxRequestSent = false;
page.on('request', (request) => {
if (
request.url().includes('/mail-domains/domainfr/mailboxes/') &&
request.method() === 'POST'
) {
isCreateMailboxRequestSent = true;
}
});
page.on(
'request',
(request) =>
(isCreateMailboxRequestSent =
request.url().includes('/mail-domains/domainfr/mailboxes/') &&
request.method() === 'POST'),
);
await interceptApiCalls();
@@ -269,9 +266,6 @@ test.describe('Mail domain create mailbox', () => {
await expect(
page.getByText('Please enter your secondary email address'),
).toBeVisible();
await expect(
page.getByText('Please enter your phone number'),
).toBeVisible();
expect(isCreateMailboxRequestSent).toBeFalsy();
});