From e0739689e690546fd2dbee0f85194df91b203fea Mon Sep 17 00:00:00 2001 From: antoine lebaud Date: Fri, 31 May 2024 12:29:58 +0200 Subject: [PATCH] =?UTF-8?q?=F0=9F=9A=A8(backend)=20handle=20new=20checks?= =?UTF-8?q?=20introduced=20in=20Pylint=20v3.2.0?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Pylint 3.2.0 introduced a new check `possibly-used-before-assignment`, which ensures variables are defined regardless of conditional statements. Some if/else branches were missing defaults. These have been fixed. --- src/backend/core/api/__init__.py | 2 ++ src/backend/core/tests/test_api_team_invitations.py | 3 +++ 2 files changed, 5 insertions(+) diff --git a/src/backend/core/api/__init__.py b/src/backend/core/api/__init__.py index b72c847..57c847b 100644 --- a/src/backend/core/api/__init__.py +++ b/src/backend/core/api/__init__.py @@ -23,6 +23,8 @@ def exception_handler(exc, context): detail = exc.message elif hasattr(exc, "messages"): detail = exc.messages + else: + detail = "" exc = drf_exceptions.ValidationError(detail=detail) diff --git a/src/backend/core/tests/test_api_team_invitations.py b/src/backend/core/tests/test_api_team_invitations.py index e4c0925..d69ad67 100644 --- a/src/backend/core/tests/test_api_team_invitations.py +++ b/src/backend/core/tests/test_api_team_invitations.py @@ -349,6 +349,8 @@ def test_api_team_invitations__update__forbidden(method): client = APIClient() client.force_login(user) + + response = None if method == "put": response = client.put( f"/api/v1.0/teams/{invitation.team.id}/invitations/{invitation.id}/", @@ -357,6 +359,7 @@ def test_api_team_invitations__update__forbidden(method): response = client.patch( f"/api/v1.0/teams/{invitation.team.id}/invitations/{invitation.id}/", ) + assert response is not None assert response.status_code == status.HTTP_405_METHOD_NOT_ALLOWED assert response.json()["detail"] == f'Method "{method.upper()}" not allowed.'