From e63c31f960b8cadccb3c254c19127f2db165a528 Mon Sep 17 00:00:00 2001
From: Laurent Bossavit <laurent.git@bossavit.com>
Date: Wed, 19 Mar 2025 20:37:57 +0100
Subject: [PATCH] =?UTF-8?q?=F0=9F=90=9B(front)=20disable=20retries=20in=20?=
 =?UTF-8?q?useQuery=20and=20useInfiniteQuery?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The default options in TanStack Query don't make sense for these purposes
and were inducing a need for long timeouts in Playwright tests. (Personal
aside: I consider timeouts in Playwright as a testing smell.)
---
 CHANGELOG.md                                                 | 5 +++++
 .../src/features/mail-domains/domains/api/useMailDomains.tsx | 1 +
 .../desk/src/features/teams/team-management/api/useTeams.tsx | 1 +
 src/frontend/apps/e2e/__tests__/app-desk/mail-domain.spec.ts | 4 +---
 .../apps/e2e/__tests__/app-desk/mail-domains-add.spec.ts     | 4 +---
 .../apps/e2e/__tests__/app-desk/teams-create.spec.ts         | 4 +---
 6 files changed, 10 insertions(+), 9 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 0630663..acb05e0 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -13,6 +13,11 @@ and this project adheres to
 - ✨(oidc) add simple introspection backend #832
 - 🧑‍💻(tasks) run management commands #814
 
+### Fixed
+
+- 🐛(oauth2) force JWT signed for /userinfo #804
+- 🐛(front) disable retries in useQuery and useInfiniteQuery #818
+
 ## [1.14.1] - 2025-03-17
 
 ## [1.14.0] - 2025-03-17
diff --git a/src/frontend/apps/desk/src/features/mail-domains/domains/api/useMailDomains.tsx b/src/frontend/apps/desk/src/features/mail-domains/domains/api/useMailDomains.tsx
index 0a491b9..26b848e 100644
--- a/src/frontend/apps/desk/src/features/mail-domains/domains/api/useMailDomains.tsx
+++ b/src/frontend/apps/desk/src/features/mail-domains/domains/api/useMailDomains.tsx
@@ -66,6 +66,7 @@ export function useMailDomains(
     getNextPageParam(lastPage, allPages) {
       return lastPage.next ? allPages.length + 1 : undefined;
     },
+    retry: 0,
     ...queryConfig,
   });
 }
diff --git a/src/frontend/apps/desk/src/features/teams/team-management/api/useTeams.tsx b/src/frontend/apps/desk/src/features/teams/team-management/api/useTeams.tsx
index ac77840..e4038da 100644
--- a/src/frontend/apps/desk/src/features/teams/team-management/api/useTeams.tsx
+++ b/src/frontend/apps/desk/src/features/teams/team-management/api/useTeams.tsx
@@ -34,5 +34,6 @@ export function useTeams(params: TeamsParams) {
   return useQuery({
     queryKey: [KEY_LIST_TEAM, params],
     queryFn: () => getTeams(params),
+    retry: 0,
   });
 }
diff --git a/src/frontend/apps/e2e/__tests__/app-desk/mail-domain.spec.ts b/src/frontend/apps/e2e/__tests__/app-desk/mail-domain.spec.ts
index ca71b41..3900769 100644
--- a/src/frontend/apps/e2e/__tests__/app-desk/mail-domain.spec.ts
+++ b/src/frontend/apps/e2e/__tests__/app-desk/mail-domain.spec.ts
@@ -136,9 +136,7 @@ test.describe('Mail domain', () => {
       page.getByText(
         'It seems that the page you are looking for does not exist or cannot be displayed correctly.',
       ),
-    ).toBeVisible({
-      timeout: 15000,
-    });
+    ).toBeVisible();
   });
 
   test.describe('user is administrator or owner', () => {
diff --git a/src/frontend/apps/e2e/__tests__/app-desk/mail-domains-add.spec.ts b/src/frontend/apps/e2e/__tests__/app-desk/mail-domains-add.spec.ts
index f57e32a..f10a8b0 100644
--- a/src/frontend/apps/e2e/__tests__/app-desk/mail-domains-add.spec.ts
+++ b/src/frontend/apps/e2e/__tests__/app-desk/mail-domains-add.spec.ts
@@ -154,8 +154,6 @@ test.describe('Add Mail Domains', () => {
       page.getByText(
         'It seems that the page you are looking for does not exist or cannot be displayed correctly.',
       ),
-    ).toBeVisible({
-      timeout: 15000,
-    });
+    ).toBeVisible();
   });
 });
diff --git a/src/frontend/apps/e2e/__tests__/app-desk/teams-create.spec.ts b/src/frontend/apps/e2e/__tests__/app-desk/teams-create.spec.ts
index afdd530..b60645f 100644
--- a/src/frontend/apps/e2e/__tests__/app-desk/teams-create.spec.ts
+++ b/src/frontend/apps/e2e/__tests__/app-desk/teams-create.spec.ts
@@ -99,8 +99,6 @@ test.describe('Teams Create', () => {
       page.getByText(
         'It seems that the page you are looking for does not exist or cannot be displayed correctly.',
       ),
-    ).toBeVisible({
-      timeout: 15000,
-    });
+    ).toBeVisible();
   });
 });