From 7bc25ad1b1494b4867a9c952499e406d4ae2b316 Mon Sep 17 00:00:00 2001 From: Jason Volk Date: Wed, 28 Jan 2026 04:46:55 +0000 Subject: [PATCH] Fix nightly clippy::unnecessary-sort-by. Signed-off-by: Jason Volk --- src/admin/user/commands.rs | 2 +- src/api/client/directory.rs | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/admin/user/commands.rs b/src/admin/user/commands.rs index 3f961d60..821f51f1 100644 --- a/src/admin/user/commands.rs +++ b/src/admin/user/commands.rs @@ -905,7 +905,7 @@ pub(super) async fn last_active(&self, limit: Option) -> Result { .ready_filter(|(ts, _)| ts.get() > uint!(0)) .collect::>() .map(|mut vec| { - vec.sort_by(|a, b| b.0.cmp(&a.0)); + vec.sort_by_key(|k| cmp::Reverse(k.0)); vec }) .map(Vec::into_iter) diff --git a/src/api/client/directory.rs b/src/api/client/directory.rs index 453ef82a..6e5e7f41 100644 --- a/src/api/client/directory.rs +++ b/src/api/client/directory.rs @@ -1,3 +1,5 @@ +use std::cmp; + use axum::extract::State; use axum_client_ip::InsecureClientIp; use futures::{ @@ -328,7 +330,7 @@ pub(crate) async fn get_public_rooms_filtered_helper( .collect() .await; - all_rooms.sort_by(|l, r| r.num_joined_members.cmp(&l.num_joined_members)); + all_rooms.sort_by_key(|r| cmp::Reverse(r.num_joined_members)); let total_room_count_estimate = UInt::try_from(all_rooms.len()) .unwrap_or_else(|_| uint!(0))