cleanup+refactor admin room alias and server account accessing to globals

Signed-off-by: strawberry <strawberry@puppygock.gay>

src/service/users/mod.rs

@@ -9,7 +9,6 @@ use data::Data;
 use ruma::{
 	api::client::{
 		device::Device,
-		error::ErrorKind,
 		filter::FilterDefinition,
 		sync::sync_events::{
 			self,
@@ -20,10 +19,10 @@ use ruma::{
 	events::AnyToDeviceEvent,
 	serde::Raw,
 	DeviceId, DeviceKeyAlgorithm, DeviceKeyId, OwnedDeviceId, OwnedDeviceKeyId, OwnedMxcUri, OwnedRoomId, OwnedUserId,
-	RoomAliasId, UInt, UserId,
+	UInt, UserId,
 };
 
-use crate::{services, Error, Result};
+use crate::{service, services, Error, Result};
 
 pub struct SlidingSyncCache {
 	lists: BTreeMap<String, SyncRequestList>,
@@ -234,18 +233,14 @@ impl Service {
 
 	/// Check if a user is an admin
 	pub fn is_admin(&self, user_id: &UserId) -> Result<bool> {
-		let admin_room_alias_id = RoomAliasId::parse(format!("#admins:{}", services().globals.server_name()))
-			.map_err(|_| Error::BadRequest(ErrorKind::InvalidParam, "Invalid alias."))?;
-		let admin_room_id = services()
-			.rooms
-			.alias
-			.resolve_local_alias(&admin_room_alias_id)?
-			.unwrap();
-
-		services()
-			.rooms
-			.state_cache
-			.is_joined(user_id, &admin_room_id)
+		if let Some(admin_room_id) = service::admin::Service::get_admin_room()? {
+			services()
+				.rooms
+				.state_cache
+				.is_joined(user_id, &admin_room_id)
+		} else {
+			Ok(false)
+		}
 	}
 
 	/// Create a new user account on this homeserver.