From ca6cf8ad1976e7817def02b57a0fafa77513a859 Mon Sep 17 00:00:00 2001 From: Jason Volk Date: Sat, 14 Feb 2026 06:48:10 +0000 Subject: [PATCH] Eliminate mutable state. Signed-off-by: Jason Volk --- src/service/client/mod.rs | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/src/service/client/mod.rs b/src/service/client/mod.rs index 05e676ed..00151fa6 100644 --- a/src/service/client/mod.rs +++ b/src/service/client/mod.rs @@ -5,7 +5,7 @@ use std::{ }; use ipaddress::IPAddress; -use reqwest::{Certificate, Client, ClientBuilder, dns::Resolve, redirect}; +use reqwest::{Certificate, Client, ClientBuilder, dns::Resolve, header::HeaderValue, redirect}; use tuwunel_core::{Config, Result, either::Either, err, implement, trace}; use crate::{Services, service}; @@ -154,12 +154,10 @@ fn make_clients(services: &Services) -> Result { } fn base(config: &Config, name: Option<&str>) -> Result { - let mut user_agent = tuwunel_core::version::user_agent(); - let user_agent_with_name; - if let Some(name) = name { - user_agent_with_name = format!("{user_agent} {name}"); - user_agent = &user_agent_with_name; - } + let user_agent = tuwunel_core::version::user_agent(); + let user_agent: HeaderValue = name + .map(|name| format!("{user_agent} {name}").try_into()) + .unwrap_or_else(|| user_agent.try_into())?; let mut builder = Client::builder() .hickory_dns(true)