studio/cunningham
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

✅(react) strip "Today, " from selected date range literal

Browse Source 
DateRangePicker aria-labels mention when a selected date range
contains today's date, which breaks the tests  while ran on the
first day of the month. Avoid these tests to be flaky.
This commit is contained in:
Lebaud Antoine
2023-08-02 00:33:08 +02:00
committed by aleb_the_flash
parent 26304791ae
commit bae7392fe1
2 changed files with 18 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
.changeset/rare-emus-wait.md Normal file
View File

@@ -0,0 +1,5 @@
---
"@openfun/cunningham-react": patch
---
Fix flaky tests on DateRangePicker

18
packages/react/src/components/Forms/DatePicker/DateRangePicker.spec.tsx
View File

@@ -241,7 +241,9 @@ describe("<DateRangePicker/>", () => {
).getByRole("button")!;
// Pick a start date.
const gridCellStartDate = startGridCellButton.getAttribute("aria-label");
const gridCellStartDate = startGridCellButton
.getAttribute("aria-label")
?.replace("Today, ", "");
await user.click(startGridCellButton);
expectCalendarToBeOpen();
@@ -254,7 +256,9 @@ describe("<DateRangePicker/>", () => {
).getByRole("button")!;
// Pick an end date.
const gridCellEndDate = endGridCellButton.getAttribute("aria-label");
const gridCellEndDate = endGridCellButton
.getAttribute("aria-label")
?.replace("Today, ", "");
await user.click(endGridCellButton);
// Calendar should close on range's selection.
@@ -273,7 +277,8 @@ describe("<DateRangePicker/>", () => {
const selectedRange = within(selectedCells[0])
.getByRole("button")!
.getAttribute("aria-label")
?.replace("selected", "");
?.replace("selected", "")
?.replace("Today, ", "");
// Make sure start and end dates are in the selected range,
// that describes the range with its start and end date.
@@ -311,7 +316,9 @@ describe("<DateRangePicker/>", () => {
).getByRole("button")!;
// Pick a start date.
const gridCellDate = gridCellButton.getAttribute("aria-label");
const gridCellDate = gridCellButton
.getAttribute("aria-label")
?.replace("Today, ", "");
await user.click(gridCellButton);
expectCalendarToBeOpen();
@@ -335,7 +342,8 @@ describe("<DateRangePicker/>", () => {
const selectedRange = within(selectedCells[0])
.getByRole("button")!
.getAttribute("aria-label")
?.replace("selected", "");
?.replace("selected", "")
?.replace("Today, ", "");
// Make sure start and end dates are in the selected range,
// that describes the range with its start and end date.