studio/meet
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

♻️(backend) refactor try/except when getting a room

Browse Source 
Be more Pythonist simplifying try except while tracking when
user is getting a room.
This commit is contained in:
lebaudantoine
2024-11-04 14:25:20 +01:00
parent 4449b578bd
commit 67d004fbda
1 changed files with 5 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/backend/core/api/viewsets.py
View File

@@ -186,13 +186,6 @@ class RoomViewSet(
""" """
try: try:
instance = self.get_object() instance = self.get_object()
analytics.track(
user=self.request.user,
event="Get Room",
properties={"slug": instance.slug},
)
except Http404: except Http404:
if not settings.ALLOW_UNREGISTERED_ROOMS: if not settings.ALLOW_UNREGISTERED_ROOMS:
raise raise
@@ -210,6 +203,11 @@ class RoomViewSet(
} }
else: else:
data = self.get_serializer(instance).data data = self.get_serializer(instance).data
analytics.track(
user=self.request.user,
event="Get Room",
properties={"slug": instance.slug},
)
return drf_response.Response(data) return drf_response.Response(data)