🎨(frontend) clarify video toggle naming and improve typing
Enhance toggle naming in video controls to explicitly indicate special processor handling functionality and improve toggleProps TypeScript typing. Makes code more self-documenting by clearly identifying processor-aware toggle behavior while strengthening type safety
This commit is contained in:
committed by
aleb_the_flash
parent
c2586a392c
commit
aa8362c470
@@ -30,7 +30,7 @@ export type ToggleDeviceProps<T extends ToggleSource> = {
|
||||
toggle: (
|
||||
forceState?: boolean,
|
||||
captureOptions?: CaptureOptionsBySource<T>
|
||||
) => Promise<void | boolean | undefined> | void
|
||||
) => Promise<void | boolean | undefined>
|
||||
context?: 'room' | 'join'
|
||||
kind: 'audioinput' | 'videoinput'
|
||||
toggleButtonProps?: Partial<ToggleButtonProps>
|
||||
|
||||
@@ -67,7 +67,7 @@ export const VideoDeviceControl = ({
|
||||
const kind = 'videoinput'
|
||||
const cannotUseDevice = useCannotUseDevice(kind)
|
||||
|
||||
const toggle = () => {
|
||||
const toggleWithProcessor = async () => {
|
||||
/**
|
||||
* We need to make sure that we apply the in-memory processor when re-enabling the camera.
|
||||
* Before, we had the following bug:
|
||||
@@ -89,7 +89,7 @@ export const VideoDeviceControl = ({
|
||||
captureOptions: VideoCaptureOptions
|
||||
) => Promise<void>
|
||||
|
||||
toggle(!trackProps.enabled, {
|
||||
await toggle(!trackProps.enabled, {
|
||||
processor: processor,
|
||||
} as VideoCaptureOptions)
|
||||
}
|
||||
@@ -106,7 +106,7 @@ export const VideoDeviceControl = ({
|
||||
<ToggleDevice
|
||||
{...trackProps}
|
||||
kind={kind}
|
||||
toggle={toggle}
|
||||
toggle={toggleWithProcessor}
|
||||
toggleButtonProps={{
|
||||
...(hideMenu
|
||||
? {
|
||||
|
||||
Reference in New Issue
Block a user