♻️(frontend) refactor tooltip on screen share toggle

Reorganize tooltip to follow others toggle buttons.
This commit is contained in:
lebaudantoine
2024-09-17 12:52:59 +02:00
committed by aleb_the_flash
parent c0ad98eb34
commit bcd285e368
4 changed files with 15 additions and 6 deletions

View File

@@ -11,13 +11,14 @@ export const ScreenShareToggle = (
'source' | 'captureOptions'
>
) => {
const { t } = useTranslation('rooms', { keyPrefix: 'controls' })
const { t } = useTranslation('rooms', { keyPrefix: 'controls.screenShare' })
const { buttonProps, enabled } = useTrackToggle({
...props,
source: Track.Source.ScreenShare,
captureOptions: { audio: true, selfBrowserSurface: 'include' },
})
const tooltipLabel = enabled ? 'stop' : 'start'
const Icon = enabled ? RiCloseFill : RiArrowUpLine
// fixme - remove ToggleButton custom styles when we design a proper icon
@@ -26,7 +27,7 @@ export const ScreenShareToggle = (
isSelected={enabled}
square
legacyStyle
tooltip={t(enabled ? 'stopScreenShare' : 'shareScreen')}
tooltip={t(tooltipLabel)}
onPress={(e) =>
buttonProps.onClick?.(
e as unknown as React.MouseEvent<HTMLButtonElement, MouseEvent>

View File

@@ -53,6 +53,10 @@
"raise": "",
"lower": ""
},
"screenShare": {
"start": "",
"stop": ""
},
"leave": "",
"participants": {
"open": "",

View File

@@ -43,8 +43,6 @@
"controls": {
"microphone": "Microphone",
"camera": "Camera",
"shareScreen": "Share screen",
"stopScreenShare": "Stop screen share",
"chat": {
"open": "Close the chat",
"closed": "Open the chat"
@@ -53,6 +51,10 @@
"raise": "Raise hand",
"lower": "Lower hand"
},
"screenShare": {
"start": "Share screen",
"stop": "Stop screen share"
},
"leave": "Leave",
"participants": {
"open": "Hide everyone",

View File

@@ -43,8 +43,6 @@
"controls": {
"microphone": "Microphone",
"camera": "Camera",
"shareScreen": "Partager l'écran",
"stopScreenShare": "Arrêter le partage",
"chat": {
"open": "Masquer le chat",
"closed": "Afficher le chat"
@@ -53,6 +51,10 @@
"raise": "Lever la main",
"lower": "Baisser la main"
},
"screenShare": {
"start": "Partager l'écran",
"stop": "Arrêter le partage"
},
"leave": "Quitter",
"participants": {
"open": "Masquer les participants",