studio/people
Archived
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

💬(frontend) change text in mail domains list

Browse Source 
- use more meaningful message
- update translations and e2e tests
This commit is contained in:
daproclaima
2024-08-09 16:23:29 +02:00
committed by Sebastien Nobour
parent 439ddb9d4a
commit b79725acbe
3 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/frontend/apps/desk/src/features/mail-domains/components/panel/ItemList.tsx
View File

@@ -86,7 +86,7 @@ const ItemListState = ({
return ( return (
<Box $justify="center" $margin="small"> <Box $justify="center" $margin="small">
<Text as="p" $margin={{ vertical: 'none' }}> <Text as="p" $margin={{ vertical: 'none' }}>
{t(`0 mail domain to display.`)} {t(`No domains exist.`)}
</Text> </Text>
</Box> </Box>
); );

2
src/frontend/apps/desk/src/i18n/translations.json
View File

@@ -9,7 +9,6 @@
"fr": { "fr": {
"translation": { "translation": {
"0 group to display.": "0 groupe à afficher.", "0 group to display.": "0 groupe à afficher.",
"0 mail domain to display.": "0 domaine de mail à afficher.",
"Accessibility statement": "Déclaration d'accessibilité", "Accessibility statement": "Déclaration d'accessibilité",
"Accessibility: non-compliant": "Accessibilité : non conforme", "Accessibility: non-compliant": "Accessibilité : non conforme",
"Add a member": "Ajouter un membre", "Add a member": "Ajouter un membre",
@@ -89,6 +88,7 @@
"My account": "Mon compte", "My account": "Mon compte",
"Names": "Noms", "Names": "Noms",
"New name...": "Nouveau nom...", "New name...": "Nouveau nom...",
"No domains exist.": "Aucun domaine existant.",
"No mail box was created with this mail domain.": "Aucune boîte mail n'a été créée avec ce nom de domaine.", "No mail box was created with this mail domain.": "Aucune boîte mail n'a été créée avec ce nom de domaine.",
"Nothing exceptional, no special privileges related to a .gouv.fr.": "Rien d'exceptionnel, pas de privilèges spéciaux liés à un .gouv.fr.", "Nothing exceptional, no special privileges related to a .gouv.fr.": "Rien d'exceptionnel, pas de privilèges spéciaux liés à un .gouv.fr.",
"Open the mail domains panel": "Ouvrir le panneau des domaines de messagerie", "Open the mail domains panel": "Ouvrir le panneau des domaines de messagerie",

4
src/frontend/apps/e2e/__tests__/app-desk/mail-domains.spec.ts
View File

@@ -141,7 +141,7 @@ test.describe('Mail domains', () => {
await expect( await expect(
page.getByLabel('mail domains panel', { exact: true }), page.getByLabel('mail domains panel', { exact: true }),
).toBeVisible(); ).toBeVisible();
await expect(page.getByText('0 mail domain to display.')).toBeVisible(); await expect(page.getByText('No domains exist.')).toBeVisible();
}); });
test('when 4 mail domains exist', async ({ page }) => { test('when 4 mail domains exist', async ({ page }) => {
@@ -165,7 +165,7 @@ test.describe('Mail domains', () => {
await expect( await expect(
page.getByLabel('mail domains panel', { exact: true }), page.getByLabel('mail domains panel', { exact: true }),
).toBeVisible(); ).toBeVisible();
await expect(page.getByText('0 mail domain to display.')).toHaveCount(0); await expect(page.getByText('No domains exist.')).toHaveCount(0);
await expect(page.getByText('domain.fr')).toBeVisible(); await expect(page.getByText('domain.fr')).toBeVisible();
await expect(page.getByText('mails.fr')).toBeVisible(); await expect(page.getByText('mails.fr')).toBeVisible();
await expect(page.getByText('versailles.net')).toBeVisible(); await expect(page.getByText('versailles.net')).toBeVisible();