🎨(backend) early return in User factory
Avoid unnecessary nesting when code can early return. Also, rename "item" to a more explicit name "user_entry". it's very nit-picking, sorry.
This commit is contained in:
committed by
aleb_the_flash
parent
b4e4940fd7
commit
43d802a73b
@@ -155,12 +155,13 @@ class TeamFactory(factory.django.DjangoModelFactory):
|
||||
@factory.post_generation
|
||||
def users(self, create, extracted, **kwargs):
|
||||
"""Add users to team from a given list of users with or without roles."""
|
||||
if create and extracted:
|
||||
for item in extracted:
|
||||
if isinstance(item, models.User):
|
||||
TeamAccessFactory(team=self, user=item)
|
||||
else:
|
||||
TeamAccessFactory(team=self, user=item[0], role=item[1])
|
||||
if not create or not extracted:
|
||||
return
|
||||
for user_entry in extracted:
|
||||
if isinstance(user_entry, models.User):
|
||||
TeamAccessFactory(team=self, user=user_entry)
|
||||
else:
|
||||
TeamAccessFactory(team=self, user=user_entry[0], role=user_entry[1])
|
||||
|
||||
|
||||
class TeamAccessFactory(factory.django.DjangoModelFactory):
|
||||
|
||||
Reference in New Issue
Block a user