studio/people
Archived
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

🎨(backend) early return in User factory

Browse Source 
Avoid unnecessary nesting when code can early return.
Also, rename "item" to a more explicit name "user_entry".

it's very nit-picking, sorry.
This commit is contained in:
Lebaud Antoine
2024-03-07 09:38:59 +01:00
committed by aleb_the_flash
parent b4e4940fd7
commit 43d802a73b
1 changed files with 7 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/backend/core/factories.py
View File

@@ -155,12 +155,13 @@ class TeamFactory(factory.django.DjangoModelFactory):
@factory.post_generation @factory.post_generation
def users(self, create, extracted, **kwargs): def users(self, create, extracted, **kwargs):
"""Add users to team from a given list of users with or without roles.""" """Add users to team from a given list of users with or without roles."""
if create and extracted: if not create or not extracted:
for item in extracted: return
if isinstance(item, models.User): for user_entry in extracted:
TeamAccessFactory(team=self, user=item) if isinstance(user_entry, models.User):
else: TeamAccessFactory(team=self, user=user_entry)
TeamAccessFactory(team=self, user=item[0], role=item[1]) else:
TeamAccessFactory(team=self, user=user_entry[0], role=user_entry[1])
class TeamAccessFactory(factory.django.DjangoModelFactory): class TeamAccessFactory(factory.django.DjangoModelFactory):